core: fix bugs where we would fetch data an epsilon too far #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3511 +/- ##
============================================
- Coverage 68.21% 68.19% -0.02%
- Complexity 1897 1898 +1
============================================
Files 411 411
Lines 20441 20450 +9
Branches 1513 1519 +6
============================================
+ Hits 13943 13946 +3
- Misses 5801 5803 +2
- Partials 697 701 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
multun
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3509
Only one of the two bugs has been reproduced in a fuzzer regression test. The other can easily be reproduced on France (and has properly been fixed), but it doesn't seem to appear on a generated infra. I suspect it only happens on very long paths, in which case we should eventually add a generated infra with extremely long tracks for better tests.