-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: migrate endpoint GET rolling_stock/{id}/livery/{id} #3519
editoast: migrate endpoint GET rolling_stock/{id}/livery/{id} #3519
Conversation
8549437
to
6a059bb
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3519 +/- ##
============================================
+ Coverage 68.31% 68.38% +0.07%
Complexity 1896 1896
============================================
Files 413 415 +2
Lines 20606 20702 +96
Branches 1519 1519
============================================
+ Hits 14076 14158 +82
- Misses 5829 5843 +14
Partials 701 701
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6a059bb
to
15560a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me but this code will be highly refactored.
We should store liveries images in the document table.
We will use the new model system to interact with the DB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR !
I've learnt about Selectable
today 😁
close #3300
rolling_stock/{id}/livery/{id}
to rustLater, we should change the database structure to use the delete on cascade (which implies removing the compound_image_id of the livery and add the livery_id in the compound_image = reverse the relationship)