-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adn/separate stdcm store #3541
Adn/separate stdcm store #3541
Conversation
This PR render the whole conf part of the store separated from simulation to stdcm. Close #3179 |
Codecov Report
@@ Coverage Diff @@
## dev #3541 +/- ##
============================================
+ Coverage 68.21% 68.30% +0.09%
Complexity 1897 1897
============================================
Files 411 411
Lines 20441 20520 +79
Branches 1513 1513
============================================
+ Hits 13944 14017 +73
- Misses 5800 5806 +6
Partials 697 697
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, can I check with you that your linter is well configured ?
Also, can you please commit your change in a new commit ('Fix comments' for instance) please ? It will be easier for me to check them :)
PS: test the scenario explorator
front/src/applications/operationalStudies/components/Scenario/getTimetable.jsx
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/components/ManageTrainSchedule/AddTrainSchedule.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/components/ManageTrainSchedule/AddTrainSchedule.tsx
Show resolved
Hide resolved
...src/applications/operationalStudies/components/ManageTrainSchedule/Itinerary/DisplayVias.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ! Can you please squash and merge your commits ?
Close #3179