Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adn/separate stdcm store #3541

Merged
merged 11 commits into from
Mar 16, 2023
Merged

Adn/separate stdcm store #3541

merged 11 commits into from
Mar 16, 2023

Conversation

alexandredamiron
Copy link
Contributor

@alexandredamiron alexandredamiron commented Mar 14, 2023

Close #3179

@alexandredamiron
Copy link
Contributor Author

alexandredamiron commented Mar 15, 2023

This PR render the whole conf part of the store separated from simulation to stdcm.
You can work on a simulation, leave this module, go to stdcm module, select different param, run the stdcm finder, then move back to the simulation module and find your older project
NOTE: the selected train is still reseted, because this info should be move to conf store part and not simulation. It will be another features

Close #3179

@alexandredamiron alexandredamiron marked this pull request as ready for review March 15, 2023 00:11
@alexandredamiron alexandredamiron requested a review from a team as a code owner March 15, 2023 00:11
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #3541 (ad4ccad) into dev (375d926) will increase coverage by 0.09%.
The diff coverage is 61.29%.

@@             Coverage Diff              @@
##                dev    #3541      +/-   ##
============================================
+ Coverage     68.21%   68.30%   +0.09%     
  Complexity     1897     1897              
============================================
  Files           411      411              
  Lines         20441    20520      +79     
  Branches       1513     1513              
============================================
+ Hits          13944    14017      +73     
- Misses         5800     5806       +6     
  Partials        697      697              
Flag Coverage Δ
front 56.35% <61.29%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/reducers/editor.ts 52.38% <0.00%> (ø)
front/src/reducers/osrdconf/index.ts 34.53% <44.57%> (+2.43%) ⬆️
...ageTrainSchedule/Itinerary/ModalPathJSONDetail.jsx 16.21% <50.00%> (+1.14%) ⬆️
front/src/reducers/osrdconf/selectors.ts 78.18% <76.92%> (-21.82%) ⬇️
...ront/src/applications/operationalStudies/consts.ts 69.87% <100.00%> (+1.12%) ⬆️
front/src/reducers/index.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@clarani clarani added the area:front Work on Standard OSRD Interface modules label Mar 15, 2023
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, can I check with you that your linter is well configured ?

Also, can you please commit your change in a new commit ('Fix comments' for instance) please ? It will be easier for me to check them :)

PS: test the scenario explorator

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! Can you please squash and merge your commits ?

@alexandredamiron alexandredamiron merged commit 6296941 into dev Mar 16, 2023
@alexandredamiron alexandredamiron deleted the adn/separateStdcmStore branch March 16, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdcm: Separate stops from OSRD Simulation
2 participants