Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: front: Migrate timetable endpoints to editoast #3542

Merged
merged 1 commit into from
Mar 23, 2023
Merged

editoast: front: Migrate timetable endpoints to editoast #3542

merged 1 commit into from
Mar 23, 2023

Conversation

bloussou
Copy link
Contributor

@bloussou bloussou commented Mar 14, 2023 •
edited
Loading

This PR is

  • migrating timetable/ endpoint to editoast with an integration test.
  • adding a test for timetable not found

close #3446
close #3447

@codecov
Copy link

codecov bot commented Mar 14, 2023 •
edited
Loading

Codecov Report

Merging #3542 (af8e149) into dev (f77533a) will decrease coverage by 0.06%.
The diff coverage is 46.93%.

@@             Coverage Diff              @@
##                dev    #3542      +/-   ##
============================================
- Coverage     68.34%   68.28%   -0.06%     
  Complexity     1917     1917              
============================================
  Files           422      425       +3     
  Lines         21244    21291      +47     
  Branches       1551     1551              
============================================
+ Hits          14519    14539      +20     
- Misses         5996     6023      +27     
  Partials        729      729
Flag Coverage Δ
editoast 74.48% <13.33%> (-0.57%) ⬇️
front 56.96% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/models/mod.rs 33.33% <ø> (ø)
editoast/src/models/timetable.rs 0.00% <0.00%> (ø)
editoast/src/tables.rs 0.00% <0.00%> (ø)
editoast/src/views/train_schedule.rs 0.00% <0.00%> (ø)
editoast/src/views/timetable.rs 20.00% <20.00%> (ø)
editoast/src/views/mod.rs 95.83% <100.00%> (+0.18%) ⬆️
...nents/SimulationResults/simulationResultsConsts.ts 100.00% <100.00%> (ø)
front/src/common/api/osrdEditoastApi.ts 91.86% <100.00%> (+0.12%) ⬆️
front/src/reducers/osrdsimulation/simulation.js 25.67% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bloussou bloussou added area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service labels Mar 15, 2023
@bloussou
Copy link
Contributor Author

waiting for #3548 to have a good integration test to be sure that there is no regression

@bloussou bloussou force-pushed the brieuc/TimetableToEditoast branch 2 times, most recently from 3e097b3 to d5e95e2 Compare March 20, 2023 11:11
@bloussou bloussou marked this pull request as ready for review March 20, 2023 13:02
@bloussou bloussou requested review from eckter and a team as code owners March 20, 2023 13:02
younesschrifi
younesschrifi reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very great PR 👍🏽

editoast/src/schema/timetable.rs Outdated Show resolved Hide resolved
editoast/src/views/timetable.rs Outdated Show resolved Hide resolved
flomonster
flomonster requested changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I've asked for some changes to match the new model system.

editoast/src/schema/timetable.rs Outdated Show resolved Hide resolved
editoast/src/schema/timetable.rs Outdated Show resolved Hide resolved
editoast/src/schema/timetable.rs Outdated Show resolved Hide resolved
editoast/src/schema/timetable.rs Outdated Show resolved Hide resolved
editoast/src/schema/train_schedule.rs Outdated Show resolved Hide resolved
editoast/src/schema/train_schedule.rs Outdated Show resolved Hide resolved
flomonster
flomonster reviewed Mar 21, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we could move some things around.

editoast/src/models/timetable.rs Outdated Show resolved Hide resolved
editoast/src/models/timetable.rs Outdated Show resolved Hide resolved
editoast/src/models/timetable.rs Outdated Show resolved Hide resolved
editoast/src/models/train_schedule.rs Outdated Show resolved Hide resolved
flomonster
flomonster approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this PR!

@bloussou bloussou requested a review from Math-R March 22, 2023 14:09
@younesschrifi younesschrifi merged commit c161593 into dev Mar 23, 2023
@younesschrifi younesschrifi deleted the brieuc/TimetableToEditoast branch March 23, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eckter eckter eckter approved these changes

@flomonster flomonster flomonster approved these changes

@Math-R Math-R Math-R approved these changes

@younesschrifi younesschrifi younesschrifi approved these changes

Assignees
No one assigned
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

api: Drop timetable api endpoints editoast: Migrate timetable endpoints
5 participants
@bloussou @eckter @flomonster @Math-R @younesschrifi