Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api : rename type field in Study model #3549

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

younesschrifi
Copy link
Contributor

Need to rename type field in Study model to migrate endpoints in editoast

@younesschrifi younesschrifi requested review from a team as code owners March 15, 2023 10:26
@younesschrifi younesschrifi force-pushed the yci/rename-type-field-into-study-type branch 4 times, most recently from 175175c to 83522a2 Compare March 15, 2023 11:01
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #3549 (c223a71) into dev (320dcc3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                dev    #3549   +/-   ##
=========================================
  Coverage     68.30%   68.30%           
  Complexity     1896     1896           
=========================================
  Files           415      415           
  Lines         20629    20629           
  Branches       1519     1519           
=========================================
  Hits          14090    14090           
  Misses         5838     5838           
  Partials        701      701           
Flag Coverage Δ
front 56.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/common/api/osrdMiddlewareApi.ts 91.55% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@younesschrifi younesschrifi force-pushed the yci/rename-type-field-into-study-type branch 4 times, most recently from 9f2d5bf to 4450244 Compare March 15, 2023 13:32
@younesschrifi younesschrifi requested review from flomonster and clarani and removed request for flomonster March 15, 2023 14:11
Tguisnet
Tguisnet previously approved these changes Mar 15, 2023
clarani
clarani previously approved these changes Mar 15, 2023
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@younesschrifi younesschrifi dismissed stale reviews from clarani and Tguisnet via 8f2ef07 March 15, 2023 15:27
@younesschrifi younesschrifi force-pushed the yci/rename-type-field-into-study-type branch 3 times, most recently from 7237940 to b9de44b Compare March 15, 2023 15:42
@younesschrifi younesschrifi force-pushed the yci/rename-type-field-into-study-type branch from b9de44b to c223a71 Compare March 15, 2023 15:44
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM !!

@younesschrifi younesschrifi merged commit 70580ec into dev Mar 15, 2023
@younesschrifi younesschrifi deleted the yci/rename-type-field-into-study-type branch March 15, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants