front: NavBar: display license attributions #3551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3551 +/- ##
============================================
+ Coverage 68.07% 68.14% +0.07%
Complexity 1897 1897
============================================
Files 420 417 -3
Lines 20983 20949 -34
Branches 1534 1534
============================================
- Hits 14284 14276 -8
+ Misses 5984 5958 -26
Partials 715 715
Flags with carried forward coverage won't be shown. Click here to find out more. see 13 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Yohh
force-pushed
the
yoh/addLicenseAttributions
branch
3 times, most recently
from
a06cc76
to
e0d2347
Compare
multun
suggested changes
Mar 15, 2023
Yohh
force-pushed
the
yoh/addLicenseAttributions
branch
from
e0d2347
to
12368be
Compare
clarani
requested changes
Mar 16, 2023
Yohh
force-pushed
the
yoh/addLicenseAttributions
branch
4 times, most recently
from
a370b24
to
f7cd37d
Compare
…collect attributions then add it to a const in consts.ts; edit translation.json - set LicenseAttributions in ReleaseInformations; change informations button to about, add translation - edit LicenseAttribution logic, remove License interface and informations translation - remove consts.ts, import licenses.json in LicenseAttributions.tsx, add script to package.json, update front readme
Yohh
force-pushed
the
yoh/addLicenseAttributions
branch
from
f7cd37d
to
f64e48d
Compare
multun
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3255