Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor: fixes issues #3318 and #3394 #3554

Merged
merged 2 commits into from
Mar 15, 2023
Merged

editor: fixes issues #3318 and #3394 #3554

merged 2 commits into from
Mar 15, 2023

Conversation

jacomyal
Copy link
Contributor

About #3318:

  • Uses each track range direction instead of trying to find which way to go by comparing current range extremities to last point crossed
  • Adds some unit tests for the routes geometry computation helpers

About #3394:

  • Since hovered entities are not accurate enough, the hovered track section is fully loaded before trying to determinate which extremity is the closest to the mouse
  • The hovered endpoint is now saved in the SwitchEditionState, and the exact same value is used when the user clicks, so that we are sure the selected endpoint is the same as the one displayed over the map

@jacomyal jacomyal requested a review from a team as a code owner March 15, 2023 13:39
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #3554 (6aed7ab) into dev (320dcc3) will decrease coverage by 0.11%.
The diff coverage is 71.08%.

❗ Current head 6aed7ab differs from pull request most recent head 7c40648. Consider uploading reports for the commit 7c40648 to get more accurate results

@@             Coverage Diff              @@
##                dev    #3554      +/-   ##
============================================
- Coverage     68.23%   68.12%   -0.11%     
  Complexity     1896     1896              
============================================
  Files           413      414       +1     
  Lines         20526    20804     +278     
  Branches       1519     1534      +15     
============================================
+ Hits          14005    14173     +168     
- Misses         5820     5915      +95     
- Partials        701      716      +15     
Flag Coverage Δ
front 56.31% <71.08%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/applications/editor/data/api.ts 31.88% <0.00%> (+3.62%) ⬆️
...rc/applications/editor/tools/routeEdition/utils.ts 43.93% <71.95%> (ø)

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sim51
sim51 previously approved these changes Mar 15, 2023
@sim51 sim51 enabled auto-merge (rebase) March 15, 2023 15:12
Details:
- Uses each track range direction instead of trying to find which way to
go by comparing current range extremities to last point crossed
- Adds some unit tests for the routes geometry computation helpers
This commit should fix issue #3394.

Details:
- Since hovered entities are not accurate enough, the hovered
track section is fully loaded before trying to determinate which
extremity is the closest to the mouse.
- The hovered endpoint is now saved in the SwitchEditionState, and the
exact same value is used when the user clicks, so that we are sure the
selected endpoint is the same as the one displayed over the map.
@sim51 sim51 merged commit 5088e52 into dev Mar 15, 2023
@sim51 sim51 deleted the ajy/issue-3318 branch March 15, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants