Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: clean GEV #3572

Merged
merged 2 commits into from
Mar 17, 2023
Merged

front: clean GEV #3572

merged 2 commits into from
Mar 17, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Mar 16, 2023

close #3573

This PR:

  • removes unused params in functions or component
  • reorders params for more clarity
  • introduces constants
  • transform the GEV which takes now only the simulation of the selected train (no need for the complete simulation + the selected train index)
  • rename variables

@clarani clarani requested a review from a team as a code owner March 16, 2023 17:11
@clarani clarani mentioned this pull request Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #3572 (7b64eab) into dev (6073cd0) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev    #3572      +/-   ##
============================================
+ Coverage     68.06%   68.15%   +0.09%     
  Complexity     1897     1897              
============================================
  Files           420      420              
  Lines         20972    21120     +148     
  Branches       1534     1535       +1     
============================================
+ Hits          14274    14394     +120     
- Misses         5983     6010      +27     
- Partials        715      716       +1     
Flag Coverage Δ
front 56.87% <100.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nents/SimulationResults/simulationResultsConsts.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Yohh
Copy link
Contributor

Yohh commented Mar 17, 2023

wunderbar!

@alexandredamiron
Copy link
Contributor

Très bien, en as tu profité pour check que mustRedraw était encore utile ? En principe il doit virer dès que possible

@clarani clarani merged commit 3c2cea6 into dev Mar 17, 2023
@clarani clarani deleted the cni/front/clean-GEV-bis branch March 17, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: refacto GEV
3 participants