front: reset GEV graph each time the selected train changes #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3578 +/- ##
=========================================
Coverage 68.36% 68.36%
Complexity 1897 1897
=========================================
Files 420 420
Lines 21206 21206
Branches 1535 1535
=========================================
Hits 14498 14498
Misses 5992 5992
Partials 716 716
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
clarani
force-pushed
the
cni/front/fix-bug-3154-gev
branch
from
9be10a4
to
1e8ea9d
Compare
clarani
changed the title
alexandredamiron
approved these changes
Mar 20, 2023
younesschrifi
pushed a commit
that referenced
this pull request
Mar 23, 2023
Closes #3154 - add an useEffect to reset the GEV graph each time the selected train changes - simplify the computation of the scale - remove mustRedraw of the GEV (manage the re-drawing of the GEV more locally)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3154