editor: fixes issue #3577 #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cause of this issue is a recent update of selectors, that made all inline selectors broken. And the editor was full of them... This commit replaces all inline selectors to external stores (internal ones were not impacted, so I'll deal with them later) by the proper ones.
Codecov Report
@@ Coverage Diff @@
## dev #3581 +/- ##
=========================================
Coverage 68.36% 68.36%
Complexity 1897 1897
=========================================
Files 420 420
Lines 21198 21201 +3
Branches 1535 1535
=========================================
+ Hits 14491 14494 +3
Misses 5991 5991
Partials 716 716
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
alexandredamiron
approved these changes
Mar 17, 2023
clarani
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause of this issue is a recent update of selectors, that made all inline selectors broken. And the editor was full of them...
This commit replaces all inline selectors to external stores (internal ones were not impacted, so I'll deal with them later) by the proper ones.