Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add a version to the redis cache #3584

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Mar 17, 2023

This is to force cache invalidation when we deploy a new version.

close #3585

This is to force cache invalidation when we deploy a new version.
@flomonster flomonster requested a review from a team as a code owner March 17, 2023 12:15
Copy link
Contributor

@multun multun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM in principle, I have not tested it to work

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #3584 (edf9658) into dev (eb9ee56) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev    #3584      +/-   ##
============================================
- Coverage     68.36%   68.36%   -0.01%     
  Complexity     1897     1897              
============================================
  Files           420      420              
  Lines         21201    21203       +2     
  Branches       1535     1535              
============================================
  Hits          14495    14495              
- Misses         5990     5992       +2     
  Partials        716      716              
Flag Coverage Δ
editoast 74.99% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/client/mod.rs 100.00% <100.00%> (ø)
editoast/src/map/layer_cache.rs 100.00% <100.00%> (ø)
editoast/src/views/mod.rs 95.65% <100.00%> (-0.19%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@flomonster flomonster merged commit 3da5e8f into dev Mar 17, 2023
@flomonster flomonster deleted the fam/redis-cache-version branch March 17, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some parts of the infra are still visible after they were deleted
3 participants