stdcm: only simulate edges up to the next stop #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #3667 +/- ##
============================================
+ Coverage 69.80% 69.83% +0.03%
- Complexity 2002 2011 +9
============================================
Files 438 438
Lines 21899 21912 +13
Branches 1658 1661 +3
============================================
+ Hits 15286 15302 +16
+ Misses 5818 5817 -1
+ Partials 795 793 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eckter
force-pushed
the
ech/stdcm-partial-edges
branch
from
502e4d4
to
ce0bc2d
Compare
Khoyo
reviewed
Mar 28, 2023
core/src/main/java/fr/sncf/osrd/stdcm/graph/STDCMSimulations.java
Outdated
Show resolved
Hide resolved
eckter
force-pushed
the
ech/stdcm-partial-edges
branch
2 times, most recently
from
9c8e140
to
60dac03
Compare
eckter
force-pushed
the
ech/stdcm-partial-edges
branch
from
60dac03
to
d44d7b1
Compare
multun
approved these changes
Apr 4, 2023
Khoyo
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing stdcm edges, we now only go up to the first stop. Before this, we always simulated an envelope over the whole route and sometimes detected invalid conflicts after the end of the path. Fixes a bug reproduced in a couple unit tests that were disabled.
First step for #3301.
To do this, there has been a problem: we sometimes need to simulate a 0-length path. To do this, I have removed the assertion in
EnvelopePartabout single point parts. The alternative would have been a new class implementing an interface shared withEnvelope, but it would be a heavier change. I'd like feedback on this.