Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix-bug: display rolling stock images #3696

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Mar 27, 2023

closes #3695

I tested my PR in local and in local with dev.

@clarani clarani marked this pull request as ready for review March 27, 2023 13:45
@clarani clarani requested a review from a team as a code owner March 27, 2023 13:45
@clarani clarani added the area:front Work on Standard OSRD Interface modules label Mar 27, 2023
bloussou
bloussou previously approved these changes Mar 27, 2023
Copy link
Contributor

@bloussou bloussou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #3696 (184d950) into dev (2b511b4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #3696   +/-   ##
=========================================
  Coverage     68.50%   68.50%           
  Complexity     1928     1928           
=========================================
  Files           426      426           
  Lines         21783    21783           
  Branches       1577     1577           
=========================================
  Hits          14922    14922           
  Misses         6113     6113           
  Partials        748      748           
Flag Coverage Δ
front 57.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@nicolaswurtz nicolaswurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use new marvelous RTK queries pleeeease :D

@nicolaswurtz nicolaswurtz merged commit e345dbb into dev Mar 28, 2023
@nicolaswurtz nicolaswurtz deleted the cni/front/fix-rs-images branch March 28, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: rolling stock images are not displayed anymore
3 participants