Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buffer stop odd location #3721

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Add buffer stop odd location #3721

merged 1 commit into from
Mar 29, 2023

Conversation

flomonster
Copy link
Contributor

close #3607

@flomonster flomonster requested review from a team as code owners March 29, 2023 12:14
@flomonster flomonster marked this pull request as draft March 29, 2023 12:14
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #3721 (18971d8) into dev (f4cd588) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev    #3721      +/-   ##
============================================
+ Coverage     68.58%   68.60%   +0.01%     
  Complexity     1928     1928              
============================================
  Files           427      427              
  Lines         21847    21860      +13     
  Branches       1577     1577              
============================================
+ Hits          14983    14996      +13     
  Misses         6116     6116              
  Partials        748      748              
Flag Coverage Δ
editoast 75.33% <100.00%> (+0.17%) ⬆️
front 57.41% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/generated_data/error/buffer_stops.rs 100.00% <100.00%> (ø)
editoast/src/schema/errors.rs 97.22% <100.00%> (+0.12%) ⬆️
editoast/src/schema/mod.rs 94.64% <100.00%> (+0.19%) ⬆️
front/src/common/api/osrdEditoastApi.ts 91.24% <100.00%> (-0.10%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@flomonster flomonster marked this pull request as ready for review March 29, 2023 12:53
@flomonster flomonster enabled auto-merge (rebase) March 29, 2023 13:06
Tguisnet
Tguisnet previously approved these changes Mar 29, 2023
clarani
clarani previously approved these changes Mar 29, 2023
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos and one remark on ordering, but LGTM

editoast/openapi.yaml Outdated Show resolved Hide resolved
editoast/src/generated_data/error/buffer_stops.rs Outdated Show resolved Hide resolved
editoast/src/generated_data/error/buffer_stops.rs Outdated Show resolved Hide resolved
@flomonster flomonster dismissed stale reviews from clarani and Tguisnet via ecfcd45 March 29, 2023 16:41
@flomonster flomonster requested a review from clarani March 29, 2023 16:41
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, your code is very clear and simple, very pleasant to review :D

@flomonster flomonster merged commit 0bf9131 into dev Mar 29, 2023
@flomonster flomonster deleted the fam/buffer-stop-odd-position branch March 29, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger a warning if a buffer stop has a suspicious location
3 participants