Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adn/condensed speed limit #3769

Merged
merged 12 commits into from
Apr 7, 2023
Merged

Adn/condensed speed limit #3769

merged 12 commits into from
Apr 7, 2023

Conversation

alexandredamiron
Copy link
Contributor

A typescripted version of SpeedLimitSelectors (gabarits for speedLimit). Also Isolation, and a story for storyBook

Capture d’écran 2023-03-31 à 12 12 52

@alexandredamiron
front pass to flex if condensed
6d617fb
@alexandredamiron
front: tsx go!
908cad1 
# Conflicts:
#	front/src/applications/operationalStudies/views/ManageTrainSchedule.tsx
@alexandredamiron
front: refacto on SpeedLimitTagSelector + story
7320521 
# Conflicts:
#	front/src/applications/operationalStudies/views/ManageTrainSchedule.tsx
@alexandredamiron
front: completedArgs
3f7425e
@alexandredamiron alexandredamiron requested a review from a team as a code owner March 31, 2023 10:13
@codecov
Copy link

codecov bot commented Mar 31, 2023 •
edited
Loading

Codecov Report

Merging #3769 (ebcdea4) into dev (b2f95cd) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #3769      +/-   ##
============================================
- Coverage     69.81%   69.73%   -0.09%     
  Complexity     2016     2016              
============================================
  Files           439      439              
  Lines         22001    22027      +26     
  Branches       1662     1662              
============================================
  Hits          15361    15361              
- Misses         5845     5871      +26     
  Partials        795      795
Flag Coverage Δ
front 58.89% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nicolaswurtz nicolaswurtz added the area:front Work on Standard OSRD Interface modules label Mar 31, 2023
clarani
clarani requested changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, some comments :)

...c/applications/operationalStudies/components/ManageTrainSchedule/SpeedLimitByTagSelector.tsx Outdated Show resolved Hide resolved
...c/applications/operationalStudies/components/ManageTrainSchedule/SpeedLimitByTagSelector.tsx Outdated Show resolved Hide resolved
...c/applications/operationalStudies/components/ManageTrainSchedule/SpeedLimitByTagSelector.tsx Outdated Show resolved Hide resolved
...c/applications/operationalStudies/components/ManageTrainSchedule/SpeedLimitByTagSelector.tsx Outdated Show resolved Hide resolved
front/src/stories/SpeedLimitByTag.stories.tsx Outdated Show resolved Hide resolved
nicolaswurtz
nicolaswurtz suggested changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@nicolaswurtz nicolaswurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component is not really isolated, it always belongs to operationalStudies folders structure.

Dedicated SCSS should be too isolated is styles/scss/common

What "withOSRDdata" is supposed to do ?

front/src/styles/scss/applications/operationalStudies/_managetrainschedule.scss Outdated Show resolved Hide resolved
front/src/styles/scss/applications/operationalStudies/_managetrainschedule.scss Outdated Show resolved Hide resolved
clarani
clarani requested changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see the component anymore + can you add data to the component in Storybook ?

image

...c/applications/operationalStudies/components/ManageTrainSchedule/SpeedLimitByTagSelector.tsx Outdated Show resolved Hide resolved
...c/applications/operationalStudies/components/ManageTrainSchedule/SpeedLimitByTagSelector.tsx Outdated Show resolved Hide resolved
...c/applications/operationalStudies/components/ManageTrainSchedule/SpeedLimitByTagSelector.tsx Outdated Show resolved Hide resolved
...c/applications/operationalStudies/components/ManageTrainSchedule/SpeedLimitByTagSelector.tsx Outdated Show resolved Hide resolved
nicolaswurtz
nicolaswurtz previously approved these changes Apr 6, 2023
View reviewed changes
clarani
clarani reviewed Apr 6, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to test, but I have issues...

front/src/common/BootstrapSNCF/SelectImprovedSNCF.scss Outdated Show resolved Hide resolved
front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.scss Outdated Show resolved Hide resolved
clarani
clarani reviewed Apr 6, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some data for Storybook ? Thanks !

front/src/stories/SpeedLimitByTag.stories.tsx Show resolved Hide resolved
front/src/stories/SpeedLimitByTag.stories.tsx Outdated Show resolved Hide resolved
front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx Outdated Show resolved Hide resolved
front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx Show resolved Hide resolved
front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx Show resolved Hide resolved
front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx Show resolved Hide resolved
front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx Outdated Show resolved Hide resolved
front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx Outdated Show resolved Hide resolved
front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx Show resolved Hide resolved
front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx Outdated Show resolved Hide resolved
clarani
clarani approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Everything seems to work on both storybook and the application 👍

front/src/common/SpeedLimitByTagSelector/SpeedLimitByTagSelector.tsx Show resolved Hide resolved
@alexandredamiron alexandredamiron merged commit de0ab45 into dev Apr 7, 2023
@alexandredamiron alexandredamiron deleted the adn/condensedSpeedLimit branch April 7, 2023 12:48
alexandredamiron added a commit that referenced this pull request Apr 7, 2023
@alexandredamiron
Adn/condensed speed limit (#3769)
60ddee8 
A typescripted version of SpeedLimitSelectors (gabarits for speedLimit).
Also Isolation, and a story for storyBook

![Capture d’écran 2023-03-31 à 12 12
52](https://user-images.githubusercontent.com/765626/229092718-f07fda62-947a-4f85-8f3d-fe9812790895.png)
leovalais pushed a commit that referenced this pull request Apr 12, 2023
@alexandredamiron @leovalais
Adn/condensed speed limit (#3769)
e9f78bb 
A typescripted version of SpeedLimitSelectors (gabarits for speedLimit).
Also Isolation, and a story for storyBook

![Capture d’écran 2023-03-31 à 12 12
52](https://user-images.githubusercontent.com/765626/229092718-f07fda62-947a-4f85-8f3d-fe9812790895.png)
multun pushed a commit that referenced this pull request Jul 18, 2023
@alexandredamiron
Adn/condensed speed limit (#3769)
d91f86b 
A typescripted version of SpeedLimitSelectors (gabarits for speedLimit).
Also Isolation, and a story for storyBook

![Capture d’écran 2023-03-31 à 12 12
52](https://user-images.githubusercontent.com/765626/229092718-f07fda62-947a-4f85-8f3d-fe9812790895.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

@nicolaswurtz nicolaswurtz nicolaswurtz left review comments

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandredamiron @nicolaswurtz @clarani