Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix zone occupancy computation on train with stops #3802

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Apr 4, 2023

Fixes #3787.

@Khoyo Khoyo added kind:bug Something isn't working area:core Work on Core Service labels Apr 4, 2023
@Khoyo Khoyo requested a review from a team as a code owner April 4, 2023 15:01
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #3802 (b4b9553) into dev (ace93ca) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev    #3802      +/-   ##
============================================
+ Coverage     69.72%   69.76%   +0.03%     
- Complexity     2010     2016       +6     
============================================
  Files           439      439              
  Lines         21935    21937       +2     
  Branches       1661     1661              
============================================
+ Hits          15295    15305      +10     
+ Misses         5845     5837       -8     
  Partials        795      795              
Flag Coverage Δ
core 79.18% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../sncf/osrd/standalone_sim/EnvelopeStopWrapper.java 94.73% <100.00%> (+22.51%) ⬆️
...f/osrd/standalone_sim/ScheduleMetadataExtractor.kt 94.69% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Khoyo Khoyo enabled auto-merge (rebase) April 4, 2023 15:10
@Khoyo Khoyo merged commit ae732bb into dev Apr 4, 2023
@Khoyo Khoyo deleted the fix-signals-stops branch April 4, 2023 15:16
@Khoyo Khoyo self-assigned this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signaling system doesn't match train stops.
2 participants