Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: api: editoast: search in projects/studies/scenarios #3816

Merged
merged 11 commits into from
Apr 13, 2023

Conversation

SharglutDev
Copy link
Contributor

close #3409

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #3816 (dd88665) into dev (c2bf981) will increase coverage by 0.02%.
The diff coverage is 96.22%.

@@             Coverage Diff              @@
##                dev    #3816      +/-   ##
============================================
+ Coverage     69.64%   69.66%   +0.02%     
  Complexity     2027     2027              
============================================
  Files           439      439              
  Lines         22162    22172      +10     
  Branches       1670     1670              
============================================
+ Hits          15434    15447      +13     
+ Misses         5928     5925       -3     
  Partials        800      800              
Flag Coverage Δ
editoast 73.86% <81.81%> (-0.04%) ⬇️
front 59.27% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/views/documents.rs 96.15% <ø> (+2.60%) ⬆️
editoast/src/views/pagination.rs 84.21% <ø> (-1.84%) ⬇️
editoast/src/views/search/config.rs 0.00% <ø> (ø)
editoast/src/views/study.rs 91.86% <ø> (-0.10%) ⬇️
editoast/src/models/projects.rs 63.49% <66.66%> (-0.58%) ⬇️
editoast/src/models/study.rs 94.11% <66.66%> (-0.33%) ⬇️
editoast/src/views/projects.rs 84.28% <100.00%> (-0.65%) ⬇️
front/src/common/api/osrdEditoastApi.ts 91.43% <100.00%> (+0.17%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@younesschrifi younesschrifi force-pushed the pfn/searchProjectsStudies branch 7 times, most recently from c7a1805 to 215667f Compare April 11, 2023 13:01
@SharglutDev SharglutDev force-pushed the pfn/searchProjectsStudies branch 2 times, most recently from eec16d3 to 8fe74f1 Compare April 12, 2023 13:16
@younesschrifi younesschrifi force-pushed the pfn/searchProjectsStudies branch 4 times, most recently from 234818b to f8214b9 Compare April 12, 2023 17:50
@younesschrifi younesschrifi force-pushed the pfn/searchProjectsStudies branch 2 times, most recently from 944965e to e93976c Compare April 12, 2023 19:12
@younesschrifi younesschrifi marked this pull request as ready for review April 12, 2023 21:19
@younesschrifi younesschrifi requested review from a team as code owners April 12, 2023 21:19
@younesschrifi younesschrifi force-pushed the pfn/searchProjectsStudies branch 6 times, most recently from 4d84634 to 76180c1 Compare April 12, 2023 22:35
flomonster
flomonster previously approved these changes Apr 12, 2023
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed editoast and API. LGTM

@younesschrifi younesschrifi force-pushed the pfn/searchProjectsStudies branch 2 times, most recently from de7a568 to 04645f4 Compare April 13, 2023 02:06
@nicolaswurtz nicolaswurtz enabled auto-merge (rebase) April 13, 2023 09:37
@nicolaswurtz nicolaswurtz enabled auto-merge (rebase) April 13, 2023 10:00
@nicolaswurtz nicolaswurtz merged commit f42e362 into dev Apr 13, 2023
@nicolaswurtz nicolaswurtz deleted the pfn/searchProjectsStudies branch April 13, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search in projects/studies
5 participants