Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: lower infra download memory usage #3818

Merged
merged 1 commit into from
Apr 7, 2023
Merged

core: lower infra download memory usage #3818

merged 1 commit into from
Apr 7, 2023

Conversation

multun
Copy link
Contributor

@multun multun commented Apr 5, 2023

No description provided.

@multun multun requested a review from a team as a code owner April 5, 2023 12:51
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #3818 (9382d35) into dev (cc83322) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #3818   +/-   ##
=========================================
  Coverage     69.77%   69.78%           
- Complexity     2016     2017    +1     
=========================================
  Files           439      439           
  Lines         21951    21951           
  Branches       1662     1662           
=========================================
+ Hits          15317    15319    +2     
+ Misses         5839     5838    -1     
+ Partials        795      794    -1     
Flag Coverage Δ
core 79.19% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/src/main/java/fr/sncf/osrd/api/InfraManager.java 74.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm too lazy to setup the tools to properly test this, but the code looks good.

How much does it reduce peak memory use?

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Reviewed + tested.

@flomonster flomonster merged commit 1cafb72 into dev Apr 7, 2023
@flomonster flomonster deleted the core-gc-download branch April 7, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants