Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize core memory usage #3850

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Optimize core memory usage #3850

merged 1 commit into from
Apr 12, 2023

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Apr 7, 2023

This PR removes switch branches (fake edge inside a switch) from the routeOnEdges multimap.
This can reduce the storage of an infra by 200MB.

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #3850 (ae800bd) into dev (d7e3bd7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ae800bd differs from pull request most recent head 1f4831b. Consider uploading reports for the commit 1f4831b to get more accurate results

@@            Coverage Diff            @@
##                dev    #3850   +/-   ##
=========================================
  Coverage     69.61%   69.62%           
+ Complexity     2017     2003   -14     
=========================================
  Files           438      439    +1     
  Lines         22052    22022   -30     
  Branches       1662     1661    -1     
=========================================
- Hits          15352    15332   -20     
+ Misses         5906     5892   -14     
- Partials        794      798    +4     
Flag Coverage Δ
core 78.85% <100.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...srd/api/pathfinding/PathfindingRoutesEndpoint.java 88.42% <ø> (-0.05%) ⬇️
...mentation/reservation/ReservationInfraBuilder.java 87.01% <100.00%> (+0.08%) ⬆️

... and 32 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@flomonster flomonster marked this pull request as ready for review April 7, 2023 14:59
@flomonster flomonster requested a review from a team as a code owner April 7, 2023 14:59
@flomonster flomonster marked this pull request as draft April 7, 2023 15:21
@flomonster flomonster marked this pull request as ready for review April 12, 2023 09:59
@multun multun merged commit b67ee2a into dev Apr 12, 2023
@multun multun deleted the fam/core-opti-mem branch April 12, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants