Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: Add signal icons for search signals #3870

Merged
merged 1 commit into from
Apr 13, 2023
Merged

front: Add signal icons for search signals #3870

merged 1 commit into from
Apr 13, 2023

Conversation

Uriel-Sautron
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron commented Apr 11, 2023 •
edited
Loading

close #3886

@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner April 11, 2023 13:39
@codecov
Copy link

codecov bot commented Apr 11, 2023 •
edited
Loading

Codecov Report

Merging #3870 (99b64ec) into dev (cdd561a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #3870   +/-   ##
=========================================
  Coverage     69.64%   69.64%           
  Complexity     2027     2027           
=========================================
  Files           439      439           
  Lines         22162    22162           
  Branches       1670     1670           
=========================================
  Hits          15435    15435           
  Misses         5927     5927           
  Partials        800      800
Flag Coverage Δ
front 59.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nicolaswurtz nicolaswurtz requested review from nicolaswurtz and removed request for nicolaswurtz April 12, 2023 13:29
@nicolaswurtz nicolaswurtz self-assigned this Apr 12, 2023
clarani
clarani reviewed Apr 13, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good ! I just need to test :)

clarani
clarani approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in local, everything is working once you have the correct data in the db ! Nice responsive behaviour ;)

image

@Uriel-Sautron Uriel-Sautron merged commit 651c40a into dev Apr 13, 2023
@Uriel-Sautron Uriel-Sautron deleted the usn/fix-search-signals-display branch April 13, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

Assignees

@nicolaswurtz nicolaswurtz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Front: Add signal icons in MapsearchSignal
3 participants
@Uriel-Sautron @clarani @nicolaswurtz