front: GEV: display power restriction on GEV #3876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yohh
force-pushed
the
yoh/createPowerRestrictionDisplayOnGEV
branch
from
fc58c8a
to
cc39c8f
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3876 +/- ##
============================================
- Coverage 69.68% 69.56% -0.12%
Complexity 2026 2026
============================================
Files 439 439
Lines 22245 22309 +64
Branches 1672 1672
============================================
+ Hits 15501 15520 +19
- Misses 5939 5984 +45
Partials 805 805
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Castavo
reviewed
Apr 12, 2023
...ications/operationalStudies/components/SimulationResults/SpeedSpaceChart/SpeedSpaceChart.jsx
Outdated
Show resolved
Hide resolved
Yohh
force-pushed
the
yoh/createPowerRestrictionDisplayOnGEV
branch
2 times, most recently
from
b0c5634
to
e9e197b
Compare
clarani
reviewed
Apr 13, 2023
...ications/operationalStudies/components/SimulationResults/SpeedSpaceChart/SpeedSpaceChart.jsx
Outdated
Show resolved
Hide resolved
...ications/operationalStudies/components/SimulationResults/SpeedSpaceChart/SpeedSpaceChart.jsx
Outdated
Show resolved
Hide resolved
...ications/operationalStudies/components/SimulationResults/SpeedSpaceChart/SpeedSpaceChart.jsx
Outdated
Show resolved
Hide resolved
Yohh
force-pushed
the
yoh/createPowerRestrictionDisplayOnGEV
branch
12 times, most recently
from
d06b3b5
to
89093fd
Compare
anisometropie
requested changes
Apr 18, 2023
…etting in SpeedSpaceSettings; update simulation.json - add condition if used and/or seen restriction is undefined - fix comments
… from SpeedSpaceChart.jsx; add condition in d3helpers.jsx; edit consts.ts with power restrictions data - group rects by restriction; add striped pattern - edit text when incompatible restriction
Yohh
force-pushed
the
yoh/createPowerRestrictionDisplayOnGEV
branch
from
89093fd
to
aced2a5
Compare
anisometropie
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3805