Speed sections edition #3890
Merged
Speed sections edition #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sim51
approved these changes
Apr 13, 2023
Details: - Adds functions to get SpeedLimits layer props outside of the existing component - Adds SpeedSections types - Adds SpeedSections layer - Drafts SpeedSectionsTool
Details: - Fixes layers order - Properly loads track sections and generate speed section geometry - Addresses lengths computation issue between back and front (still buggy but not crashy at least...)
Details: - Clicking an unlinked track section links it - Clicking a linked track range unlinks it - Clicking an extremity starts editing - Pressing Escape stops editing it
jacomyal
force-pushed
the
ajy/editor-speed-sections
branch
from
1809219
to
f5bfccd
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3890 +/- ##
============================================
- Coverage 69.64% 69.63% -0.01%
Complexity 2026 2026
============================================
Files 439 439
Lines 22186 22202 +16
Branches 1672 1672
============================================
+ Hits 15451 15460 +9
- Misses 5930 5937 +7
Partials 805 805
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds speed sections edition to the infrastructure editor.
Missing features: