core: fix the offset of signals inside blocks #3891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khoyo
requested changes
Apr 13, 2023
core/kt-osrd-signaling/src/main/kotlin/fr/sncf/osrd/signaling/impl/BlockBuilder.kt
Outdated
Show resolved
Hide resolved
When building blocks, the length of some zone paths was appended to blocks they did not belong to. The issue was fixed by updating the length of blocks at the same time as building its list of zone paths.
multun
force-pushed
the
fix-block-signal-offset
branch
from
90564d2
to
3419258
Compare
Khoyo
approved these changes
Apr 13, 2023
Codecov Report
@@ Coverage Diff @@
## dev #3891 +/- ##
============================================
- Coverage 69.64% 69.62% -0.02%
+ Complexity 2027 2026 -1
============================================
Files 439 439
Lines 22162 22176 +14
Branches 1669 1672 +3
============================================
+ Hits 15434 15440 +6
- Misses 5928 5931 +3
- Partials 800 805 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building blocks, the length of some zone paths was appended to blocks they did not belong to. The issue was fixed by updating the length of blocks at the same time as building its list of zone paths.