Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix PTO import with stop #3894

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

bloussou
Copy link
Contributor

@bloussou bloussou commented Apr 13, 2023

correct computation of train duration to avoid negative train duration

@bloussou bloussou added the area:front Work on Standard OSRD Interface modules label Apr 13, 2023
@bloussou bloussou requested a review from a team as a code owner April 13, 2023 13:17
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #3894 (8ceaf48) into dev (651c40a) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #3894      +/-   ##
============================================
+ Coverage     69.64%   69.67%   +0.02%     
  Complexity     2027     2027              
============================================
  Files           439      439              
  Lines         22162    22205      +43     
  Branches       1670     1670              
============================================
+ Hits          15435    15471      +36     
- Misses         5927     5934       +7     
  Partials        800      800              
Flag Coverage Δ
front 59.27% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bloussou bloussou force-pushed the brieuc/FixImportTrainScheduleWithPause branch from 7dd3f8a to 8ceaf48 Compare April 13, 2023 13:28
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for not letting this go ! =)

@Math-R Math-R enabled auto-merge (rebase) April 13, 2023 13:33
@Math-R Math-R merged commit 57323b9 into dev Apr 13, 2023
@Math-R Math-R deleted the brieuc/FixImportTrainScheduleWithPause branch April 13, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants