core: fix pathfinding response waypoints #4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #4991 +/- ##
=========================================
Coverage 18.55% 18.55%
- Complexity 2466 2469 +3
=========================================
Files 859 859
Lines 106263 106267 +4
Branches 2499 2500 +1
=========================================
+ Hits 19714 19718 +4
Misses 85182 85182
Partials 1367 1367
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eckter
reviewed
Sep 7, 2023
core/src/main/java/fr/sncf/osrd/api/pathfinding/PathfindingResultConverter.java
Outdated
Show resolved
Hide resolved
flomonster
force-pushed
the
fam/fix-core-pf
branch
from
f18bbbd
to
1f8e6e7
Compare
multun
reviewed
Sep 11, 2023
core/src/main/java/fr/sncf/osrd/api/pathfinding/response/PathWaypointResult.java
Outdated
Show resolved
Hide resolved
flomonster
force-pushed
the
fam/fix-core-pf
branch
from
452e248
to
2d6c535
Compare
eckter
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the application, we assume that the number of waypoints given as input to the PF must match the number of waypoints output (unsuggested) by core.
When two waypoints are at the same location, they are merged into a single unsuggested waypoint. This PR fixes this.
Merge this after: #4655