Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix path projection on backward chunks #5060

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Sep 15, 2023

Fix #5037

@eckter eckter requested a review from a team as a code owner September 15, 2023 08:39
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo UnitTests to fix, LGTM!

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #5060 (b37fc6e) into dev (04b21aa) will increase coverage by 0.00%.
Report is 3 commits behind head on dev.
The diff coverage is 90.90%.

@@            Coverage Diff            @@
##                dev    #5060   +/-   ##
=========================================
  Coverage     22.00%   22.01%           
- Complexity     2450     2455    +5     
=========================================
  Files           852      852           
  Lines         89252    89261    +9     
  Branches       2480     2482    +2     
=========================================
+ Hits          19639    19647    +8     
  Misses        68254    68254           
- Partials       1359     1360    +1     
Flag Coverage Δ
core 79.46% <90.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...srd/api/pathfinding/PathfindingBlocksEndpoint.java 88.33% <85.71%> (-0.18%) ⬇️
.../fr/sncf/osrd/sim_infra/impl/PathPropertiesImpl.kt 91.91% <100.00%> (+0.25%) ⬆️

@eckter eckter added this pull request to the merge queue Sep 15, 2023
Merged via the queue into dev with commit d39fab4 Sep 15, 2023
5 checks passed
@eckter eckter deleted the ech/fix-path-projection branch September 15, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

impossible to create a train on certain parts of the infrastructure
3 participants