Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix several white screens bugs #5103

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Sep 20, 2023

closes #5101, closes #5097 (front)

  • in SpaceTimeChart, add a test when drawing the train (on trainHeadPosition)
  • in Timeline, add a test to check if there is data or not
  • in DriverTrainScheduleStopList, change the key of the stops

- in SpaceTimeChart, add a test when drawing the train (on trainHeadPosition)
- in Timeline, add a test to check if there is data or not
- in DriverTrainScheduleStopList, change the key of the stops
@clarani clarani added the area:front Work on Standard OSRD Interface modules label Sep 20, 2023
@clarani clarani requested a review from a team as a code owner September 20, 2023 09:41
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #5103 (20a0cac) into dev (2a5dfd3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #5103      +/-   ##
============================================
- Coverage     21.57%   21.57%   -0.01%     
  Complexity     2455     2455              
============================================
  Files           863      863              
  Lines         91148    91149       +1     
  Branches       2503     2503              
============================================
  Hits          19664    19664              
- Misses        70113    70114       +1     
  Partials       1371     1371              
Flag Coverage Δ
front 8.43% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...riverTrainSchedule/DriverTrainScheduleStopList.tsx 0.00% <0.00%> (ø)
...ents/SimulationResults/SpaceTimeChart/drawTrain.ts 0.00% <0.00%> (ø)
...components/SimulationResults/TimeLine/TimeLine.jsx 0.00% <0.00%> (ø)

@Math-R Math-R added this pull request to the merge queue Sep 20, 2023
Merged via the queue into dev with commit 2a5cbf4 Sep 20, 2023
4 of 5 checks passed
@Math-R Math-R deleted the cni-front-5101-fix-white-screens branch September 20, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: multiple white screen errors White screen when trains in opposite directions arrive at the same point
2 participants