Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix invalid switch deletion #6034

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

SharglutDev
Copy link
Contributor

close #6011

@SharglutDev SharglutDev requested a review from a team as a code owner December 6, 2023 11:07
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (1a763d9) 26.53% compared to head (1d2a97d) 26.51%.
Report is 2 commits behind head on dev.

Files Patch % Lines
...src/applications/editor/components/EntitySumUp.tsx 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6034      +/-   ##
============================================
- Coverage     26.53%   26.51%   -0.03%     
  Complexity     2117     2117              
============================================
  Files           930      930              
  Lines        122630   122724      +94     
  Branches       2669     2669              
============================================
- Hits          32543    32542       -1     
- Misses        88510    88605      +95     
  Partials       1577     1577              
Flag Coverage Δ
core 78.97% <ø> (ø)
editoast 74.55% <ø> (-0.01%) ⬇️
front 9.32% <0.00%> (-0.01%) ⬇️
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/fix-invalid-switch-deletion branch from fdd42e0 to 1d2a97d Compare December 6, 2023 14:46
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

@SharglutDev SharglutDev added this pull request to the merge queue Dec 6, 2023
Merged via the queue into dev with commit 5f6870c Dec 6, 2023
17 checks passed
@SharglutDev SharglutDev deleted the pfn/front/fix-invalid-switch-deletion branch December 6, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selecting a switch with missing port causes infinite loading
2 participants