Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor: fixes saving a new speed section #6443

Merged
merged 1 commit into from
Jan 29, 2024
Merged

editor: fixes saving a new speed section #6443

merged 1 commit into from
Jan 29, 2024

Conversation

jacomyal
Copy link
Contributor

@jacomyal jacomyal commented Jan 25, 2024

Fixes #6413. When saving an entity in Editoast, the returned railjson stores the entity id as id and not entityId, as the code suggested.

@jacomyal jacomyal requested a review from a team as a code owner January 25, 2024 09:58
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1358104) 27.87% compared to head (8680857) 27.87%.

Files Patch % Lines
...cations/editor/tools/rangeEdition/tool-factory.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6443      +/-   ##
============================================
- Coverage     27.87%   27.87%   -0.01%     
  Complexity     2167     2167              
============================================
  Files          1007     1007              
  Lines        126918   126918              
  Branches       2585     2585              
============================================
- Hits          35381    35380       -1     
- Misses        90042    90043       +1     
  Partials       1495     1495              
Flag Coverage Δ
core 78.56% <ø> (ø)
editoast 75.46% <ø> (-0.01%) ⬇️
front 8.65% <0.00%> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.44% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sim51 sim51 enabled auto-merge January 25, 2024 10:24
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@sim51 sim51 added this pull request to the merge queue Jan 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 25, 2024
Fixes #6413. When saving an entity in Editoast, the returned railjson
stores the entity id as `id` and not `entityId`, as the code suggested.
@jacomyal jacomyal changed the title front: editor: fixes #6413 editor: fixes saving a new speed section Jan 29, 2024
@SharglutDev SharglutDev added this pull request to the merge queue Jan 29, 2024
Merged via the queue into dev with commit 5d50762 Jan 29, 2024
21 checks passed
@SharglutDev SharglutDev deleted the ajy/6413 branch January 29, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: editor: clicking twice the "Save" button on new speed section creates the speed section twice
3 participants