core: set up of a standard formatter #6591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6591 +/- ##
============================================
- Coverage 28.06% 27.87% -0.19%
+ Complexity 2179 2177 -2
============================================
Files 1037 1040 +3
Lines 128014 127608 -406
Branches 2621 2610 -11
============================================
- Hits 35924 35574 -350
+ Misses 90561 90503 -58
- Partials 1529 1531 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
woshilapin
force-pushed
the
wsl/style/google-format
branch
2 times, most recently
from
ba385f0
to
9aa18f7
Compare
woshilapin
force-pushed
the
wsl/style/google-format
branch
from
9aa18f7
to
cf2d99f
Compare
`checkstyle` is not enough for a few reasons: - it doesn't provide anything to format (from command line for example) - different format, even pretty esoteric, might pass the `checkstyle` - programmers won't even agree on which of the different format should be adopted on each or each other case Google formatter is pretty standard one, I already used it and had never the need to think about it anymore... which should be the whole purpose of a formatter. https://medium.com/@ryconoclast/why-you-should-use-a-code-formatter-4f02dd40db14
woshilapin
force-pushed
the
wsl/style/google-format
branch
from
cf2d99f
to
5bb1be1
Compare
|
In the end, 4 space indentation was chosen. Although, we picked a fork of Google Java formatter, the Palantir Java formatter which seemed nicer in some cases (never ideal anyway 🤷). |
Khoyo
approved these changes
Feb 9, 2024
multun
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkstyleis not enough for a few reasons:checkstyleGoogle formatter is pretty standard one, I already used it and had never the need to think about it anymore... which should be the whole purpose of a formatter.
https://medium.com/@ryconoclast/why-you-should-use-a-code-formatter-4f02dd40db14