-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: set up of a standard formatter #6591
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6591 +/- ##
============================================
- Coverage 28.06% 27.87% -0.19%
+ Complexity 2179 2177 -2
============================================
Files 1037 1040 +3
Lines 128014 127608 -406
Branches 2621 2610 -11
============================================
- Hits 35924 35574 -350
+ Misses 90561 90503 -58
- Partials 1529 1531 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ba385f0
to
9aa18f7
Compare
9aa18f7
to
cf2d99f
Compare
`checkstyle` is not enough for a few reasons: - it doesn't provide anything to format (from command line for example) - different format, even pretty esoteric, might pass the `checkstyle` - programmers won't even agree on which of the different format should be adopted on each or each other case Google formatter is pretty standard one, I already used it and had never the need to think about it anymore... which should be the whole purpose of a formatter. https://medium.com/@ryconoclast/why-you-should-use-a-code-formatter-4f02dd40db14
cf2d99f
to
5bb1be1
Compare
In the end, 4 space indentation was chosen. Although, we picked a fork of Google Java formatter, the Palantir Java formatter which seemed nicer in some cases (never ideal anyway 🤷). |
checkstyle
is not enough for a few reasons:checkstyle
Google formatter is pretty standard one, I already used it and had never the need to think about it anymore... which should be the whole purpose of a formatter.
https://medium.com/@ryconoclast/why-you-should-use-a-code-formatter-4f02dd40db14