front: refacto of error management #6663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6663 +/- ##
============================================
+ Coverage 27.79% 27.87% +0.08%
Complexity 2172 2172
============================================
Files 1043 1043
Lines 128732 128726 -6
Branches 2570 2569 -1
============================================
+ Hits 35777 35882 +105
+ Misses 91469 91359 -110
+ Partials 1486 1485 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sim51
force-pushed
the
bsi/error-messages-front
branch
3 times, most recently
from
fdf6a4b
to
1cde71b
Compare
sim51
force-pushed
the
bsi/error-messages-front
branch
from
1cde71b
to
89e1a6b
Compare
Follows the PR on the generation of I18N keys for API errors. This commit : - centralized the code where we cast error for notification - use i18n for name and message
sim51
force-pushed
the
bsi/error-messages-front
branch
from
89e1a6b
to
07c6906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/osrd-project/osrd-confidential/issues/281#issuecomment-1948412084 for more details
Follows the PR on the generation of I18N keys for API errors. This PR :