-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: refacto of error management #6663
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6663 +/- ##
============================================
+ Coverage 27.79% 27.87% +0.08%
Complexity 2172 2172
============================================
Files 1043 1043
Lines 128732 128726 -6
Branches 2570 2569 -1
============================================
+ Hits 35777 35882 +105
+ Misses 91469 91359 -110
+ Partials 1486 1485 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fdf6a4b
to
1cde71b
Compare
1cde71b
to
89e1a6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job, thx. It's clear & concise. A few comment although ;)
Follows the PR on the generation of I18N keys for API errors. This commit : - centralized the code where we cast error for notification - use i18n for name and message
89e1a6b
to
07c6906
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, thx!
See https://github.com/osrd-project/osrd-confidential/issues/281#issuecomment-1948412084 for more details
Follows the PR on the generation of I18N keys for API errors. This PR :