Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix power restrictions warnings #6878

Merged
merged 1 commit into from
Mar 19, 2024
Merged

front: fix power restrictions warnings #6878

merged 1 commit into from
Mar 19, 2024

Conversation

SharglutDev
Copy link
Contributor

close #6543

@codecov Codecov
Copy link

codecov bot commented Mar 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.66667% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 28.75%. Comparing base (110eb8b) to head (7822399).

Files Patch % Lines
.../ManageTrainSchedule/PowerRestrictionsSelector.tsx 0.00% 53 Missing ⚠️
...eTrainSchedule/helpers/powerRestrictionSelector.ts 83.51% 0 Missing and 15 partials ⚠️
...inschedule/components/ManageTrainSchedule/types.ts 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #6878      +/-   ##
============================================
+ Coverage     28.71%   28.75%   +0.04%     
  Complexity     2244     2244              
============================================
  Files          1066     1068       +2     
  Lines        131892   131961      +69     
  Branches       2672     2688      +16     
============================================
+ Hits          37873    37949      +76     
+ Misses        92480    92457      -23     
- Partials       1539     1555      +16
Flag Coverage Δ
core 79.79% <ø> (ø)
editoast 74.88% <ø> (ø)
front 9.06% <50.66%> (+0.07%) ⬆️
gateway 2.49% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/managetrainschedule/fix-power-restrictions-warning branch 2 times, most recently from 6e55e1a to 0915184 Compare March 17, 2024 15:13
@SharglutDev SharglutDev marked this pull request as ready for review March 18, 2024 08:03
@SharglutDev SharglutDev requested a review from a team as a code owner March 18, 2024 08:03
achrafmohye
achrafmohye approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@achrafmohye achrafmohye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

Akctarus
Akctarus approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty for the tests !

clarani
clarani requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, thanks for the PR and the tests :)

front/public/locales/fr/operationalStudies/manageTrainSchedule.json Outdated Show resolved Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/PowerRestrictionsSelector.tsx Outdated Show resolved Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/PowerRestrictionsSelector.tsx Outdated Show resolved Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/types.ts Show resolved Hide resolved
...src/modules/trainschedule/components/ManageTrainSchedule/helpers/powerRestrictionSelector.ts Outdated Show resolved Hide resolved
...inschedule/components/ManageTrainSchedule/helpers/__tests__/powerRestrictionSelector.spec.ts Outdated Show resolved Hide resolved
clarani
clarani approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested ✅

@SharglutDev SharglutDev force-pushed the pfn/front/managetrainschedule/fix-power-restrictions-warning branch from 7c4c04c to 7822399 Compare March 19, 2024 07:25
@clarani clarani enabled auto-merge March 19, 2024 07:42
@clarani clarani added this pull request to the merge queue Mar 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2024
@SharglutDev SharglutDev added this pull request to the merge queue Mar 19, 2024
Merged via the queue into dev with commit a982c4c Mar 19, 2024
22 checks passed
@SharglutDev SharglutDev deleted the pfn/front/managetrainschedule/fix-power-restrictions-warning branch March 19, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achrafmohye achrafmohye achrafmohye approved these changes

@clarani clarani clarani approved these changes

@Akctarus Akctarus Akctarus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double warning message for power restrictions
4 participants
@SharglutDev @achrafmohye @clarani @Akctarus