-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix power restrictions warnings #6878
front: fix power restrictions warnings #6878
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6878 +/- ##
============================================
+ Coverage 28.71% 28.75% +0.04%
Complexity 2244 2244
============================================
Files 1066 1068 +2
Lines 131892 131961 +69
Branches 2672 2688 +16
============================================
+ Hits 37873 37949 +76
+ Misses 92480 92457 -23
- Partials 1539 1555 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6e55e1a
to
0915184
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ty for the tests !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, thanks for the PR and the tests :)
front/public/locales/fr/operationalStudies/manageTrainSchedule.json
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/PowerRestrictionsSelector.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/PowerRestrictionsSelector.tsx
Outdated
Show resolved
Hide resolved
...src/modules/trainschedule/components/ManageTrainSchedule/helpers/powerRestrictionSelector.ts
Outdated
Show resolved
Hide resolved
...inschedule/components/ManageTrainSchedule/helpers/__tests__/powerRestrictionSelector.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested ✅
7c4c04c
to
7822399
Compare
close #6543