Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix last e2e test (stdcm test) & remove the enable tag in e2e tests #6969

Merged
merged 1 commit into from
Mar 28, 2024
Merged

front: fix last e2e test (stdcm test) & remove the enable tag in e2e tests #6969

merged 1 commit into from
Mar 28, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Mar 22, 2024

closes #5510

@clarani clarani requested a review from a team as a code owner March 22, 2024 12:52
@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 28.95%. Comparing base (ac390a7) to head (7b43be0).

Files Patch % Lines
front/src/common/Pathfinding/Pathfinding.tsx 0.00% 15 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #6969      +/-   ##
============================================
- Coverage     28.95%   28.95%   -0.01%     
  Complexity     2244     2244              
============================================
  Files          1070     1070              
  Lines        132524   132528       +4     
  Branches       2713     2713              
============================================
- Hits          38377    38373       -4     
- Misses        92570    92578       +8     
  Partials       1577     1577
Flag Coverage Δ
core 79.81% <ø> (ø)
editoast 74.85% <ø> (-0.02%) ⬇️
front 9.29% <0.00%> (-0.01%) ⬇️
gateway 2.45% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani changed the title front: fix stdcm e2e test front: fix last e2e test (stdcm test) Mar 22, 2024
Yohh
Yohh reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thank you for this last refacto!

1 comment

front/tests/pages/simulation-conf-page.ts Show resolved Hide resolved
Uriel-Sautron
Uriel-Sautron approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, thank you for your work

Yohh
Yohh approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

Math-R
Math-R approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@clarani clarani changed the title front: fix last e2e test (stdcm test) front: fix last e2e test (stdcm test) & remove the enable tag in e2e tests Mar 28, 2024
@clarani
front: fix last stdcm e2e
7b43be0 
+ remove the enable tag in e2e tests
@clarani clarani enabled auto-merge March 28, 2024 15:32
@clarani clarani added this pull request to the merge queue Mar 28, 2024
Merged via the queue into dev with commit 481083c Mar 28, 2024
22 checks passed
@clarani clarani deleted the cni-5510-e2e-stcdm branch March 28, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yohh Yohh Yohh approved these changes

@Math-R Math-R Math-R approved these changes

@Uriel-Sautron Uriel-Sautron Uriel-Sautron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: refacto E2E tests: stdcm between two trains
4 participants
@clarani @Yohh @Math-R @Uriel-Sautron