-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt Infra to ModelV2 #6975
Adapt Infra to ModelV2 #6975
Conversation
e5f0faa
to
ebc7921
Compare
ebc7921
to
5265e96
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6975 +/- ##
============================================
- Coverage 29.04% 28.99% -0.06%
Complexity 2244 2244
============================================
Files 1070 1070
Lines 132780 132723 -57
Branches 2708 2713 +5
============================================
- Hits 38570 38477 -93
- Misses 92634 92669 +35
- Partials 1576 1577 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5265e96
to
118f0fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR. Thanks 👏 (review + tested)
closes #6033
Tip
Review each commit individually.
Infra-related changes
infra
tableChangeset<Infra>
instead ofInfraForm
where it makes senseTest changes
test_infra_and_delete
bytest_infra_transaction
TestFixture<T: Model>
enhancementsModelV2 changes
Patch<M>.changeset
field public