Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: adapt import train schedules v2 #7172

Merged
merged 1 commit into from
Apr 23, 2024
Merged

front: adapt import train schedules v2 #7172

merged 1 commit into from
Apr 23, 2024

Conversation

RomainValls
Copy link
Contributor

@RomainValls RomainValls commented Apr 10, 2024 •
edited
Loading

closes #7026

@RomainValls RomainValls force-pushed the rvs/front-adapt-import-train-schedule-v2 branch from 8abbc9c to 2c8576b Compare April 10, 2024 15:09
@RomainValls RomainValls marked this pull request as ready for review April 16, 2024 06:42
@RomainValls RomainValls requested a review from a team as a code owner April 16, 2024 06:42
@RomainValls RomainValls requested review from clarani, kmer2016 and Akctarus and removed request for kmer2016 April 16, 2024 06:43
@RomainValls RomainValls force-pushed the rvs/front-adapt-import-train-schedule-v2 branch from 812d3ed to dce75bb Compare April 19, 2024 08:00
clarani
clarani reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR 👏 I left some comments to clean a bit the code ;)

front/src/applications/operationalStudies/views/v2/ImportTrainScheduleV2.tsx Outdated Show resolved Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfigV2.tsx Outdated Show resolved Hide resolved
...src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleTrainsListV2.tsx Outdated Show resolved Hide resolved
...src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleTrainsListV2.tsx Outdated Show resolved Hide resolved
...src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleTrainsListV2.tsx Outdated Show resolved Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/generateTrainSchedulesPayload.ts Outdated Show resolved Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/generateTrainSchedulesPayload.ts Show resolved Hide resolved
...src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleTrainsListV2.tsx Outdated Show resolved Hide resolved
...src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleTrainsListV2.tsx Outdated Show resolved Hide resolved
...src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleTrainsListV2.tsx Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 2.40000% with 244 lines in your changes are missing coverage. Please review.

Project coverage is 28.39%. Comparing base (0bf04ff) to head (7f781c4).
Report is 5 commits behind head on dev.

Files Patch % Lines
...ortTrainSchedule/generateTrainSchedulesPayloads.ts 0.00% 104 Missing and 1 partial ⚠️
...tTrainSchedule/ImportTrainScheduleTrainsListV2.tsx 0.00% 56 Missing ⚠️
...mportTrainSchedule/ImportTrainScheduleConfigV2.tsx 0.00% 34 Missing ⚠️
front/src/applications/operationalStudies/types.ts 0.00% 17 Missing ⚠️
front/src/utils/timeManipulation.ts 26.08% 17 Missing ⚠️
...rationalStudies/views/v2/ImportTrainScheduleV2.tsx 0.00% 7 Missing ⚠️
...s/ImportTrainSchedule/ImportTrainScheduleModal.tsx 0.00% 3 Missing ⚠️
...cations/operationalStudies/views/v2/ScenarioV2.tsx 0.00% 2 Missing ⚠️
...rtTrainSchedule/ImportTrainScheduleTrainDetail.tsx 0.00% 2 Missing ⚠️
.../ImportTrainSchedule/generatePathfindingPayload.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7172      +/-   ##
============================================
+ Coverage     28.35%   28.39%   +0.03%     
- Complexity     2006     2022      +16     
============================================
  Files          1139     1148       +9     
  Lines        139899   139683     -216     
  Branches       2707     2727      +20     
============================================
- Hits          39666    39656      -10     
+ Misses        98615    98403     -212     
- Partials       1618     1624       +6
Flag Coverage Δ
core 78.05% <ø> (-0.16%) ⬇️
editoast 70.10% <ø> (-0.51%) ⬇️
front 9.19% <2.40%> (+0.04%) ⬆️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

clarani
clarani reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some small comments, but it's almost good for me, great job :)

...src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleTrainsListV2.tsx Outdated Show resolved Hide resolved
...src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleTrainsListV2.tsx Outdated Show resolved Hide resolved
front/src/modules/trainschedule/components/ImportTrainSchedule/generateTrainSchedulesPayload.ts Outdated Show resolved Hide resolved
front/src/utils/timeManipulation.ts Outdated Show resolved Hide resolved
@RomainValls RomainValls force-pushed the rvs/front-adapt-import-train-schedule-v2 branch from 60bd60f to 3e4a331 Compare April 23, 2024 08:18
clarani
clarani approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job ✅

@RomainValls
front: adapt import train schedules v2
7f781c4 
fix comments

fix comments

fix comments
@RomainValls RomainValls force-pushed the rvs/front-adapt-import-train-schedule-v2 branch from cfc131a to 7f781c4 Compare April 23, 2024 10:43
@RomainValls RomainValls removed the request for review from Akctarus April 23, 2024 10:53
@RomainValls RomainValls added this pull request to the merge queue Apr 23, 2024
Merged via the queue into dev with commit b86407f Apr 23, 2024
17 checks passed
@RomainValls RomainValls deleted the rvs/front-adapt-import-train-schedule-v2 branch April 23, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: adapt ImportTrainSchedule to trainSchedule v2
3 participants
@RomainValls @codecov-commenter @clarani