-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: add get rolling stock by name endpoint #7243
Conversation
9f9b92e
to
c3f6590
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7243 +/- ##
============================================
+ Coverage 28.20% 28.35% +0.15%
- Complexity 2289 2299 +10
============================================
Files 1128 1142 +14
Lines 139471 139928 +457
Branches 2801 2845 +44
============================================
+ Hits 39335 39680 +345
- Misses 98505 98598 +93
- Partials 1631 1650 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly lgtm, just some details:
b229322
to
e8138fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, thanks!
e8138fb
to
24be174
Compare
758c585
to
9a1a454
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9a1a454
to
ef54189
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. You can rest now :)
28acdcb
to
d8afe65
Compare
d8afe65
to
05f2e75
Compare
When the script found an error definition in openapi.yml file, it tries to generate its message with a dummy variable object. And this object can't be well defined, specially for objects. This leads to an error for the script, even if it's valid.
Add an enpoint to retrieve a rolling stock given its name.