editoast: add get rolling stock by name endpoint #7243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younesschrifi
force-pushed
the
yci/add_rolling_stock_by_name_endpoint
branch
from
9f9b92e
to
c3f6590
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7243 +/- ##
============================================
+ Coverage 28.20% 28.35% +0.15%
- Complexity 2289 2299 +10
============================================
Files 1128 1142 +14
Lines 139471 139928 +457
Branches 2801 2845 +44
============================================
+ Hits 39335 39680 +345
- Misses 98505 98598 +93
- Partials 1631 1650 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leovalais
requested changes
Apr 17, 2024
younesschrifi
force-pushed
the
yci/add_rolling_stock_by_name_endpoint
branch
3 times, most recently
from
b229322
to
e8138fb
Compare
younesschrifi
force-pushed
the
yci/add_rolling_stock_by_name_endpoint
branch
from
e8138fb
to
24be174
Compare
younesschrifi
force-pushed
the
yci/add_rolling_stock_by_name_endpoint
branch
2 times, most recently
from
758c585
to
9a1a454
Compare
younesschrifi
force-pushed
the
yci/add_rolling_stock_by_name_endpoint
branch
from
9a1a454
to
ef54189
Compare
SharglutDev
approved these changes
Apr 18, 2024
younesschrifi
force-pushed
the
yci/add_rolling_stock_by_name_endpoint
branch
2 times, most recently
from
28acdcb
to
d8afe65
Compare
younesschrifi
force-pushed
the
yci/add_rolling_stock_by_name_endpoint
branch
from
d8afe65
to
05f2e75
Compare
When the script found an error definition in openapi.yml file, it tries to generate its message with a dummy variable object. And this object can't be well defined, specially for objects. This leads to an error for the script, even if it's valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an enpoint to retrieve a rolling stock given its name.