core: stdcm: set block to route map even if path ended #7284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7284 +/- ##
============================================
+ Coverage 28.39% 29.13% +0.73%
+ Complexity 2022 2020 -2
============================================
Files 1148 1137 -11
Lines 139683 139713 +30
Branches 2727 2755 +28
============================================
+ Hits 39669 40701 +1032
+ Misses 98390 97403 -987
+ Partials 1624 1609 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eckter
force-pushed
the
ech/bugfix-stdcm
branch
2 times, most recently
from
c23092b
to
d7c52a9
Compare
Erashin
approved these changes
Apr 23, 2024
shenriotpro
reviewed
Apr 26, 2024
core/src/main/kotlin/fr/sncf/osrd/stdcm/infra_exploration/InfraExplorer.kt
Outdated
Show resolved
Hide resolved
eckter
force-pushed
the
ech/bugfix-stdcm
branch
from
d7c52a9
to
d4f6dd9
Compare
shenriotpro
reviewed
Apr 26, 2024
core/src/main/kotlin/fr/sncf/osrd/stdcm/infra_exploration/InfraExplorer.kt
Outdated
Show resolved
Hide resolved
shenriotpro
approved these changes
May 2, 2024
core/src/main/kotlin/fr/sncf/osrd/stdcm/infra_exploration/InfraExplorer.kt
Show resolved
Hide resolved
We used to not add entries in some cases, and the map was shared across different instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bugfix, the other loop sometimes stops early