Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add ToSchema to all infra schemas #7306

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Apr 24, 2024

Part of #7048

@hamz2a hamz2a requested a review from a team as a code owner April 24, 2024 15:10
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.09%. Comparing base (4b7e3d7) to head (6f58bce).
Report is 28 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7306      +/-   ##
============================================
+ Coverage     28.52%   29.09%   +0.57%     
- Complexity     2004     2020      +16     
============================================
  Files          1144     1137       -7     
  Lines        138828   139647     +819     
  Branches       2705     2757      +52     
============================================
+ Hits          39605    40635    +1030     
+ Misses        97605    97403     -202     
+ Partials       1618     1609       -9     
Flag Coverage Δ
core 76.76% <ø> (-1.62%) ⬇️
editoast 72.08% <100.00%> (+0.04%) ⬆️
front 9.34% <ø> (+0.14%) ⬆️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a force-pushed the hai/editoast-add-ToSchema-to-all-infra-items branch from a1d667d to 69df751 Compare April 25, 2024 13:44
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR

editoast/editoast_schemas/src/infra.rs Outdated Show resolved Hide resolved
editoast/editoast_schemas/src/infra/buffer_stop.rs Outdated Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-add-ToSchema-to-all-infra-items branch from 69df751 to cf6bb19 Compare April 26, 2024 14:48
@hamz2a hamz2a requested a review from flomonster April 26, 2024 14:48
@hamz2a hamz2a force-pushed the hai/editoast-add-ToSchema-to-all-infra-items branch from cf6bb19 to 58f035f Compare April 26, 2024 15:05
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have extensions that are not inline.

@hamz2a hamz2a force-pushed the hai/editoast-add-ToSchema-to-all-infra-items branch from 58f035f to 370b69d Compare April 30, 2024 10:10
@hamz2a
Copy link
Contributor Author

hamz2a commented Apr 30, 2024

You still have extensions that are not inline.

Done.

@hamz2a hamz2a requested a review from flomonster April 30, 2024 10:10
editoast/editoast_schemas/src/infra/signal.rs Outdated Show resolved Hide resolved
editoast/editoast_schemas/src/infra/speed_section.rs Outdated Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-add-ToSchema-to-all-infra-items branch from 370b69d to 6f58bce Compare April 30, 2024 13:37
@hamz2a hamz2a added this pull request to the merge queue Apr 30, 2024
Merged via the queue into dev with commit f72ba7f Apr 30, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-add-ToSchema-to-all-infra-items branch April 30, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants