editoast: replace actix_web::web::Data by Arc in models

[hamz2a]

Part of #6980

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.84%. Comparing base (5b12cb9) to head (c354aed).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@              Coverage Diff              @@
##                dev    #7418       +/-   ##
=============================================
+ Coverage     29.15%   54.84%   +25.69%     
=============================================
  Files          1164       67     -1097     
  Lines        144102     3878   -140224     
  Branches       2811        0     -2811     
=============================================
- Hits          42013     2127    -39886     
+ Misses       100428     1751    -98677     
+ Partials       1661        0     -1661     

Flag	Coverage Δ
core	?
editoast	?
front	?
gateway	2.41% <ø> (ø)
railjson_generator	87.49% <ø> (ø)
tests	83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leovalais]

Thanks for this cleanup that's long overdue! :D

I'd replace the occurrences of db_pool.clone().into_inner() by db_pool.into_inner() directly when possible. When it's not, I'd prefer to extract the Arc first and then clone the arc directly.
That doesn't block this PR, but I'd rather get rid of the Data as early as possible.

foo(db_pool.clone().into_inner());
bar(db_pool.into_inner());

// would become

let db_pool = db_pool.into_inner();
foo(db_pool.clone());
bar(db_pool);

(You can use sed -y to swap clone() and into_inner() to quickly spot the places that need that change.)

This will likely conflict with #7281

[leovalais]

LGTM, thanks! :)