-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement : Add fields for projects metadata #1221
Comments
That would make a lot of sense! The original source and format of the data could be tracked there. This might also be useful for rich format imports (such as https://specs.frictionlessdata.io/data-package/ ). |
@wetneb Interesting ! Open refine has become a sort of data warehouse for me, and for others also I guess. It is widely used in the information sciences community. For a librarian, not being able to add metadata is a torture. |
Some ideas here: #1045 |
We have an offer for $ 250 (100 missing) https://www.bountysource.com/issues/47809745-enhancement-add-fields-for-projects-metadata |
Hey @denim2x, welcome! Can you give us an idea of what your plans would be for this feature? There are various issues related to project metadata (see the tag:
metadata
|
Here is a summary of the comments and suggestion from the different tickets together (adding few of my own). Feel free to comment and enrich. List of meta to create:
Make the list of project sortable by metadata (from #657) Meta information are available from |
Dublin Core can be an inspiration for metadata fields, although not all of the fifteen elements are needed in this case. Title |
Thanks a lot @magdmartin for this summary of the other issues! That's very convenient. I think it would also be good to have other generic metadata fields as @ettorerizza proposes. We really should keep #778 and #1096 in mind for that. This document gives some ideas about what sort of metadata data packages provide: https://www.w3.org/TR/2015/PR-tabular-metadata-20151117/ If we want to support these sort of formats, I think it would be reasonable to designate a list of core metadata fields (things that apply to all OpenRefine projects and would be exposed in the UI) and also provide some support for custom metadata provided by the original import format. This extra metadata could be reused by exporters or extensions (so that, for instance, no metadata is lost if you import a data package, clean it, and export it to another data package). |
@wetneb PLease clarify: do you require PR-tabular-metadata conformance for this issue? |
@denim2x I think the Tabular Metadata specification goes way beyond what @ettorerizza had in mind when he started his issue and bounty. So I do not think implementing that should be required to close this issue. However, solving this issue will probably involve some changes to the model, possibly impacting the format in which projects are persisted (if we want to add fields that cannot be stored yet). Doing this sort of change is slightly complicated: we might need to adapt the importers so that they fill the fields we introduce, ensure the existing workspaces will be migrated seamlessly to the format that supports the new fields, and so on. So, this relatively heavy change should be made with the other use cases in mind: ideally, we should avoid further model changes and adopt a model that works for a wide range of metadata needs. That does not mean the UI should fully expose the flexibility of this new model, or anything. But maybe that will turn out to be too complicated and therefore out of the scope of this issue. I just want us to have that discussion and not rush too much on adding very particular fields without stepping back and looking at the bigger picture. |
Hi to all, I know that comment s a little bit out of discussion but I'd like to stimulate some discussion in this sense.. |
@wetneb Are you considering using Apache Arrow in OpenRefine? |
@denim2x I don't know! Do you think it would make sense to use it to solve this issue? I am not familiar at all with that. |
Breathe everyone. :) Don't worry about compatibility with external projects. Others outside of OpenRefine can take that task because its just simple JSON with our existing metadata format. @fpompermaier We have a plan, long term for bigger data under Performance Improvements 2017 All -
|
My initial idea was to have fields directly editable right next to the project name, but a key-value menu like preferences makes a lot of sense. I just want to mention a possible UI implementation already used by Google Fusion tables. A screencast will be clearer than my explanations. |
@ettorerizza Yeap, that's the idea, an ABOUT or ? question mark button next to each project name that can open up a table of KEY / VALUE columns similar to our preferences.vt Also, being able to click checkboxes (up to perhaps max 4, or whatever works) those KEY's Values that you want to "SHOW ON PROJECT PAGE" as an additional column (space available) for easier instant viewing when the project page shows. |
@thadguidry @wetneb Any further information for working on this feature would be very appreciated |
@ettorerizza It'd be nice if you could provide some mockups with the improved UI (with steps) |
@denim2x Personally, I do not have any other expectations than those mentioned above: key-value fields that allow the user to add custom metadata to each project and a summary table of the metadata that allows to sorts and find project by date, by keywords, by title, etc. @thadguidry or @magdmartin probably have a more precise and more general view of what the enhancement should look like in practice. |
@denim2x any news about this? Let us know if you have any question about the feature. |
Is anyone able to connect to BountySource? https://salt.bountysource.com/teams/openrefine |
@ettorerizza it looks like their SSL certificate expired yesterday - I expect it will be renewed soon. I don't think they ran away with your bounty ^^ |
I have a little concern. I haven't received my payment after more than 2 months. I was told that "the payment though cheque is rare". |
@jackyq2015 yeah, actually maybe we should have a discussion about Bountysource… it has a number of issues so we might want to switch to something else instead.
I quite like Liberapay (https://liberapay.com/ ), which is actively maintained and has a smaller service fee (basically just the payment processing fees of their bank). It does not allow to put bounties on specific issues though. |
@ettorerizza I fixed the table width issue. Not perfect as I said. but much better. :) Also the refresh issue was fixed. Please have a try. |
@jackyq2015 thanks a lot for taking my rants into account! That was quick! I have just tried the new projects view and it looks great! Here are a few other things:
|
@wetneb Thanks for the feedback. I agreed all of them. I will be working on the improvement. For that 3 mysterious link at left hand, I think we can just give them a label instead of hiding it. Also we can remove the header borders for those 3. For the "about" view, are you suggesting to remove the background of "edit" button to make it fit? Any thoughts? |
Pushed the code. It is much better now! cheers |
I would suggest to close this issue if there is no objection. Please raise issue if there is any. |
@jackyq2015 it looks much better now! I still see a few points that we can still discuss:
If you're fed up with these UI tweaks let me know, I can do them :) I just think it's important to keep the UI as clean as we can, especially for a part that is seen a lot. One nice byproduct of this change is that the delete buttons are now always visible - I remember that it took me a while to figure out how to delete a project and that is now much clearer! |
Oh, and two other things (sorry):
|
@weblate please see below:
|
@wetneb @jackyq2015 My Comments are in italics above. |
The "source" key in import metadata is not enough to tell which importer was used! For instance, if it's just from the clipboard (and in general not all file names indicate their format correctly, and the user might have chosen a different importer)… So I think it would really be worth storing that explicitly! I'm curious to know if users want to see ISO timestamps rather than human-formatted dates… I think it looks quite hacky (especially with all the useless "000Z" at the end…). If you prefer to see dates rather than time deltas, then dates should be human-readable too. Think about our non-programmer users: they should not have to know about ISO timestamps to use OpenRefine! |
Jacky just need to make the fields selectable to display or not. That probably will solve your problem better. |
How about shorten the date to such as "2017-11-11 07:25 PM" ? The rename and about font is already small. Also I can reduce the width of "Row Count" a little bit but not too much(the header has to fit in) |
Above was done by PR #1323 |
I agree "Rename" and "About" take a lot of space… That's why I think "Rename" should be removed. I don't see any reason why this shortcut should be kept:
|
@wetneb @jackyq2015 If I rely on my own practices, it's true that I rename projects much more often while they are open. But I do not know if everyone does it that way. |
I will remove the "Rename" link from the index page if there is no objection by next Monday before release 2.7.2. All, please speak out if you want to keep it as is. |
"Rename link" was removed by PR #1324 |
@jackyq2015 in the end do we have tests for this feature? |
Thanks a lot for all this work, @jackyq2015 ! As I said above, you already deserved the bounty with the first draft. The system as it suits me perfectly. However, I wonder if it's ready for a public release. There are still some display issues that could frustrate users. The dates display in Chrome or Edge on a 15-inch screen with a 100% zoom is perfectible, but that's just aesthetics: Note that there is not this problem with Firefox: But in every browsers, the metadata editing window comes out of the screen again. Each time you have to zoom out to access the "edit" buttons. There is also a small problem of consistency between the "transform" window, which is displayed all along the screen, and other edit windows, which remained the same. All this annoys me very little. I set Open Refine on a 90% screen zoom. But I'm afraid it looks a little buggy in an official version 2.7.2. What do you think, everyone? |
@ettorerizza Yes, these need to be cleaned up a bit in our CSS files. Next Release is blocked until these UI issues can be cleaned up. |
@ettorerizza I understand you concern. Do you mind open 2 issues(or more if you want) for metadata and the transform UI. In the meantime, I will take a look what we can do |
@ettorerizza @wetneb @thadguidry created PR #1331. Please try / review. |
I have close to 300 projects in my workspace directory. Some have several years. The problem is I don't know where the data comes from, when exactly I processed them (two years ago, OK, but what month / day?), or sometimes simply what they correspond to. It should be recorded somewhere, for example, in metadata fields beside the project name.
I do not know if it's difficult to implement. If someone else is interested, maybe we could associate to launch a decent bounty? I already put 150 dollars on BountySource.
The text was updated successfully, but these errors were encountered: