-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type_strict option should be exposed in reconciliation UI #1424
Comments
I remembered what it does... any - At least 1 type in query must be present on the entity in the graph for it to be returned all - All types in query must be present on the entity in the graph for it to be returned should - i think this was a 50% rule where at least 50% or more of the types must be present on the entity in the graph for it to be returned. (say an entity has 4 types in graph, and query is type_strict providing 2 of the types, but entity will not be returned since not 50% of types, but of providing 3 of the types present on the entity, then it would be returned - 75% of types matching) |
okay, so that assumes we let the user choose multiple types, which isn't currently possible |
@wetneb right, its support was for multiple types. |
Adding the reconciliation API design tag because the semantics of this parameter are not fully known and we might want to rethink how this is expected to work before implementing in the client (OpenRefine). |
I think |
Actually, the original Freebase Suggest API documentation is available on archive.org and it says:
|
@tfmorris Sorry, I should have updated this issue after I found the info 3 years ago. Actually, I did eventually remember that Andi Vajda and I documented on the Freebase Wiki very well and had to use my email search to find what it was called, "filter constraints".... that eventually got translated into the official API docs... It's combining behavior is documented here (scroll down just a bit):
|
@tfmorris thanks a lot for this fantastic archeological finding! It could be worth adding this to the reconciliation API specs (both in 0.1 and current draft). |
The |
When configuring a reconciliation, we could let users decide if type matching is strict or loose. There is already a "type_strict" parameter in the specs but it isn't exposed in the UI and we are not sure what the original meaning of this option was.
See wetneb/openrefine-wikibase#4
The text was updated successfully, but these errors were encountered: