Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wikidata datavalue rendering cache ignores property #2046

Closed
wetneb opened this issue May 22, 2019 · 0 comments · Fixed by #2062
Closed

Wikidata datavalue rendering cache ignores property #2046

wetneb opened this issue May 22, 2019 · 0 comments · Fixed by #2062
Assignees
@wetneb
Labels
pull request pending For issues that will be fixed by an open PR Type: Bug Issues related to software defects or unexpected behavior, which require resolution. wikibase Related to wikidata/wikibase integration
Projects
Wikidata integration
Milestone
3.2

Comments

@wetneb
Copy link
Sponsor Member

wetneb commented May 22, 2019

Describe the bug
The cache of rendered statement values in the Wikidata preview only caches by value, not by property, so adding the same value in two different properties will be rendered in the same way, which is not desirable for external identifiers where the formatter URL varies.

To Reproduce
Steps to reproduce the behavior:

  1. Create a schema adding the same twitter id and facebook id to an item
  2. Observe that in the preview, the links are identical (so one of them is incorrect)

In OR 3.2 beta.
@wetneb wetneb added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. wikibase Related to wikidata/wikibase integration labels May 22, 2019
@wetneb wetneb self-assigned this Jun 6, 2019
@wetneb wetneb added this to Todo in Wikidata integration via automation Jun 6, 2019
wetneb added a commit that referenced this issue Jun 6, 2019
@wetneb
Fix datavalue rendering cache. Closes #2046.
09c89ef
@wetneb wetneb mentioned this issue Jun 6, 2019
Merged
@wetneb wetneb added this to the 3.2 milestone Jun 6, 2019
@wetneb wetneb added the pull request pending For issues that will be fixed by an open PR label Jun 6, 2019
@wetneb wetneb moved this from Todo to In progress in Wikidata integration Jun 6, 2019
Wikidata integration automation moved this from In progress to Done Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wetneb wetneb

Labels
pull request pending For issues that will be fixed by an open PR Type: Bug Issues related to software defects or unexpected behavior, which require resolution. wikibase Related to wikidata/wikibase integration
Projects
No open projects
Wikidata integration
  
Done
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

Fix datavalue rendering cache in Wikidata preview OpenRefine/OpenRefine
1 participant
@wetneb