New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search/filter to project list page #2749
Comments
AdjustmentsWith subtle changes to the existing
ul#tagsUl {
margin: ;
padding: 0;
left: 60px; // add left to make room for magnifying glass icon
} #projectTags {
position: relative;
padding: 3px 10px;
margin: 0px; //change to 0px from 5px
font-size: 130%;
border-radius: 5px;
-moz-border-radius: 5px;
-webkit-border-radius: 5px;
background: #bcf;
min-height: 18px;
height: auto;
overflow: auto;
}
Prototype visualizationUnclicked magnifying glass icon (Material.io Icon) : Clicked magnifying glass icon (showing icon highlighted with background contrasting) with Example code
|
|
The standard Google approach of searching everything makes the most sense. I've clarified the description. |
Hi @thadguidry if there is no one working on this issue, I would like to give it a try. Thank you! |
@mayralgr That would be great. Thanks for volunteering! I've assigned the issue to you. Let us know if you need any help. Yes, searching the project metadata fields such as name, description, etc is what's needed. The original issue was updated with that clarification. |
@mayralgr Yes, the current provided metadata for projects should be searchable. The UI prototype is just 1 possible look and feel, but feel free to slightly diverge from that if it makes more sense. It would be awesome if the listing could be updated dynamically while users began to type in matching terms, but that is not a hard requirement, and might be unfeasible given your skills or our current architecture that might prevent that kind of development. At a minimum, the listing can be updated after a user types in a term or terms and then hits their ENTER key to initiate the query to update the listing. Your choice on what works well, is easier, or feels right for now. We can iterate on it as you progress on your branch and the community provides feedback on your work. |
hi @wetneb please can you assign me this issue? thanks |
@khadijm I have already assigned you a few issues, maybe that is good enough for a start? Once you have closed those we can assign you more :) |
thanks @wetneb, i will start with draft PR soon |
Hello. @wetneb could you please assign me to this issue? |
Okay, thank you @thadguidry |
Hello @thadguidry. I have successfully run the project and reviewed what @mayralgr did in #3394. However, I don't see the work done in #3394. It seems the old PR had not been merged. How would you want me to continue now? |
@Babi-B You should be able to checkout that PR. and then create a new branch based on it and call it whatever you want locally, and then submit a new PR yourself with your GitHub credentials. In GitHub interface, when viewing a PR you can click on the <> Code button in top right and see options on how to checkout the PR, depending on your preference. (If you use Visual Studio Code, you can add the GitHub PR extension directly from Microsoft to more easily navigate any open source repo you need) Also, PR's in GitHub are basically branches themselves of a Git repo, but carry special metadata for GitHub. |
@thadguidry okay. Thanks |
Hello @thadguidry. I have checked out @mayralgr's PR and also gone through the comments. There are some things I wish to point out :
Should I make a PR so you review the work yourself? |
@Babi-B Great! Now what are your feelings about what to do about them, or not do. In regards to 3. we need to keep original functionality which is "Create Project", no matter the browser. |
@thadguidry I wish to work on the issues. |
Hello, @thadguidry @wetneb @antoine2711. While I continue working I'll like to give an update on what I've been able to do so far.
OpenRefine.test.mp4
I'm still working on this |
Hello, @wetneb @thadguidry. Could you please review this? |
For users with many projects an easy way to narrow down the list would be to provide a search function with filters the list to those with project names, descriptions, or other metadata which have substring matches with the user's input.
This could take the form of a simple text input field at the top of the page with the standard magnifying glass search icon.
The text was updated successfully, but these errors were encountered: