Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI edits to schema selection and edits saving in Wikibase extension #5346

Closed
lozanaross opened this issue Oct 16, 2022 · 2 comments · Fixed by #5935
Closed

UI edits to schema selection and edits saving in Wikibase extension #5346

lozanaross opened this issue Oct 16, 2022 · 2 comments · Fixed by #5935
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. wikibase Related to wikidata/wikibase integration
Milestone

Comments

@lozanaross
Copy link

This has been mentioned in previous PRs and issues, but starting a new issue to track all the final adjustments needed in more detail. This is a request to improve the following UI features:
Screenshot 2022-10-16 at 21 45 24

  1. I think this text is not needed - it's too clunky in the layout; it's information experienced users know and don't need to see at all times; it's also something new users should learn from tutorials / documentation; new users (as shown during user testing) tend not to read small text anyway, and just click around until they find the solution to go forth, or just go and watch a tutorial;
  2. Save schema should be called "Save schema progress".
  3. Save schema progress / Discard changes should move below the main schema editing area (see wireframes).
  4. This should probably just say "Select..."
  5. "Save new" is potentially confusing if users just want to save and override an existing schema. Another idea was to keep the button to say only "Save", but I think this will make it potentially confusing next to the dropdown in case users decide they are just saving their selection choice. I propose we call this button "Save schema edits" and we move it to the right of the screen (see wireframes).

Proposed solution

Proposed redesign:
Screenshot 2022-10-16 at 23 59 48

For more context see complete design wireframes accessible via this link: https://docs.google.com/document/d/1uWkrid1UJwM3FCak_fI4VUY2EUabVUUFk9z6OeWtzKs/edit?usp=sharing

Alternatives considered

Several previous iterations can be seen in the wireframe versions in the link above. The naming of the "Save" button and the schema vs schema template was discussed in more detail in previous PRs, e.g. #5303

Additional context

The need to adjust this was discussed during the final round of user testing for the Commons extension project carried out Sept / Oct 2022.

@lozanaross lozanaross added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Oct 16, 2022
@thadguidry thadguidry added wikibase Related to wikidata/wikibase integration and removed Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Oct 17, 2022
@Ololad-e
Copy link

@lozanaross hello I’m Ololade, Outreachy Applicant and I’d like to contribute to this issue as I have some ideas I’d like to implement on dealing with the issues, can you please assign this to me? I’ve started working on the design UI

@wetneb
Copy link
Sponsor Member

wetneb commented Mar 12, 2023

This issue is already a design proposal on its own, so I do not think there is much left to design @OloladeOdus. Perhaps it is worth picking another issue where the desired behaviour and appearance is not clear yet?

Abbe98 added a commit to Abbe98/OpenRefine that referenced this issue Jun 19, 2023
Abbe98 added a commit that referenced this issue Jun 30, 2023
* Wikibase: Layout and label changes to schema alignment tab

Implements/fixes #5346
@wetneb wetneb added this to the 3.8 milestone Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. wikibase Related to wikidata/wikibase integration
Projects
Archived in project
Status: SDC (WMF) grant 2021-22 - done
Development

Successfully merging a pull request may close this issue.

4 participants