Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy configuration still not working #5476

Closed
tledoux opened this issue Nov 27, 2022 · 0 comments · Fixed by #5477
Closed

Proxy configuration still not working #5476

tledoux opened this issue Nov 27, 2022 · 0 comments · Fixed by #5477
Labels
Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone
3.8

Comments

@tledoux
Copy link
Contributor

tledoux commented Nov 27, 2022

In OpenRefine 3.6.2, the configuration of proxy is half working after the implementation of #3919.

Indeed, the nonProxyHosts parameter is no taking into account which prevents the use case where some services are outside (access through the proxy) and others are inside the institution (access without the proxy).

The following configuration in openrefine.l4j.ini:

-Dhttp.proxyHost=myproxy.mydomain.org
-Dhttp.proxyPort=8080
-Dhttp.nonProxyHosts="*.mydomain.org|localhost|127.0.0.1"

should use the proxy myproxy.mydomain.org for all the hosts except the ones in *.mydomain.org

currently the proxy isused for all the hosts
@tledoux tledoux added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Nov 27, 2022
tledoux added a commit to tledoux/OpenRefine that referenced this issue Nov 27, 2022
@tledoux
Handle proxy configuration, closes OpenRefine#5476
1453ff7
@tledoux tledoux mentioned this issue Nov 27, 2022
Merged
@wetneb wetneb removed the Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators label Dec 15, 2022
wetneb pushed a commit that referenced this issue Feb 9, 2023
@tledoux
Handle proxy configuration, closes #5476 (#5477)
89e6dbe 
* Handle proxy configuration, closes #5476

* typos
@wetneb wetneb added this to the 3.8 milestone Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
3.8
Development

Successfully merging a pull request may close this issue.

Handle proxy configuration, closes #5476 tledoux/OpenRefine
2 participants
@wetneb @tledoux