-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve look and feel of the issues tab of the Wikibase extension #5702
Comments
Could I be assigned to this issue? |
Proposed Solution:
Alternatives considered: P.S. |
That looks much nicer, thank you! I still think we could find a better icon set for the warnings but that's likely a matter of taste. |
If unable to find consistent icons, we could try color-coding the issues. Red-Critical, Orange-Important, Yellow-Warning(as is used in many places), Blue-Information. I was looking around for a suitable icon set; maybe we can try using MediaWiki's icon for warning, information, critical. They may seem plain as compared to our current icons. Still, they go well with our current design style(IMO). |
Ah yes, without icons it could work well too (but the colors should be compatible with color blindness). |
Yes actually, I was looking for 'Important' but there doesn't seem to be any in their library. |
I think this looks really a lot cleaner, but I am curious to hear what others think. |
yeap! cleaner, clear. I would slightly increase the size if we could on the yellow icons and blue icon. They appear slightly smaller in scale to the red icon. Let's try to even out the size of them if we could. Other than that I'd stretch the lowercase i vertically just a bit, to make sure it shows more readily as an i |
Sure! |
@prashasti-7 I don't have strong feelings about the left border on each element div, but looks OK. Hmm, the longer yellow border in your screenshot just gave me some questions for @wetneb ... @wetneb I don't know if we wanted to sort things better here also? |
I think this new design is great and could already be implemented relatively easily, hence the "Good first issue" label. |
Hello, i would like to be assigned this issue. Also, should I consider implementing a sidebar for each error as suggested, or would it be better to not include it? |
Fantastic! Personally I find the side color bars pretty nice, but of course it would already be a great improvement without them. |
In the Wikibase extension, we offer a tab which displays various issues detected in the edits generated by the current Wikibase schema.
I made this UI but I find it pretty ugly:
How could this be improved? Perhaps there are other changes we could think of to make this part of the UI more inviting?
The text was updated successfully, but these errors were encountered: