Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reconciliation judgment facets resizable like other text facets #5908

Closed
wetneb opened this issue Jun 8, 2023 · 0 comments · Fixed by #5918
Closed

Make reconciliation judgment facets resizable like other text facets #5908

wetneb opened this issue Jun 8, 2023 · 0 comments · Fixed by #5918
Assignees
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. reconciliation Related to the reconciliation operations and other features Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Milestone

Comments

@wetneb
Copy link
Sponsor Member

wetneb commented Jun 8, 2023

The facets for reconciliation judgment seem to be intentionally not resizable and it is not clear to me it is a good thing.
The number of choices display in the facet can grow after the facet was created, which will cause the choices to overflow and make the facet unusable.
Also, the visual inconsistency between this facet and others is confusing to me as a user.

To Reproduce

Steps to reproduce the behavior:

  1. First, reconcile a column, which creates a judgment facet - this one is resizable.
  2. Second, delete that facet and re-create it from the Reconcile -> Facets menu. It is not resizable.
  3. Then, mark some cells as being matched to new items
  4. Finally, observe the glitch in facet rendering

Current Results

Initially (note the absence of resizing slider in the judgment facet):
image

After marking items as new (note the overflowing "Facet by choice counts"):
image

Expected Behavior

Make the facet resizable like all others and do not overflow when choices change.

Versions

  • Operating System: Debian
  • Browser Version: Firefox
  • JRE or JDK Version: 17
  • OpenRefine: 3.8-SNAPSHOT (master)
@wetneb wetneb added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. reconciliation Related to the reconciliation operations and other features labels Jun 8, 2023
@elebitzero elebitzero self-assigned this Jun 12, 2023
@tfmorris tfmorris added this to the 3.8 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. reconciliation Related to the reconciliation operations and other features Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants