Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made facet by judgment resizable #5918

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Made facet by judgment resizable #5918

merged 1 commit into from
Jun 14, 2023

Conversation

elebitzero
Copy link
Member

Fixes #5908

Changes proposed in this pull request:

  • Made facet by judgement resizable and scrollable.

@github-actions github-actions bot added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. reconciliation Related to the reconciliation operations and other features labels Jun 13, 2023
wetneb
wetneb approved these changes Jun 13, 2023
View reviewed changes
Copy link
Sponsor Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I actually wonder if any of the facets with scroll: false should actually stay like that, because the scenario I described in the issue might well apply to those as well… Happy either way.

@elebitzero elebitzero merged commit 3fe1073 into OpenRefine:master Jun 14, 2023
14 checks passed
@elebitzero
Copy link
Member Author

@wetneb I'll also check Best Type Match and Best Candidate Name Match. I will fix them also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wetneb wetneb wetneb approved these changes

Assignees
No one assigned
Labels
Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. reconciliation Related to the reconciliation operations and other features Type: Bug Issues related to software defects or unexpected behavior, which require resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make reconciliation judgment facets resizable like other text facets
2 participants
@elebitzero @wetneb