GREL string concatentation (+) overly aggressive #6341
Assignees
Labels
grel
The default expression language, GREL, could be improved in many ways!
Priority: Low
Indicates less critical issues that can be dealt with at a later stage
Type: Bug
Issues related to software defects or unexpected behavior, which require resolution.
Milestone
Comments
tfmorris
added
Type: Bug
tfmorris
added a commit
to tfmorris/OpenRefine
that referenced
this issue
Feb 2, 2024
- restrict string concatenation (+) to cases where at least one operand is a string (to avoid things like concatenating two dates as strings) - Add support for dates and strings to comparison operators Strings use a collator for the default locale with normalized decomposition for the comparisons. - Above implementation uses Comparable, so any future data types that implement that interface should get supported for free - Add a bunch more tests
tfmorris
added a commit
to tfmorris/OpenRefine
that referenced
this issue
Feb 2, 2024
- restrict string concatenation (+) to cases where at least one operand is a string (to avoid things like concatenating two dates as strings) - Add support for dates and strings to comparison operators Strings use a collator for the default locale with normalized decomposition for the comparisons. - Above implementation uses Comparable, so any future data types that implement that interface should get supported for free - Add a bunch more tests
tfmorris
added a commit
that referenced
this issue
Feb 14, 2024
- restrict string concatenation (+) to cases where at least one operand is a string (to avoid things like concatenating two dates as strings) - Add support for dates and strings to comparison operators Strings use a collator for the default locale with normalized decomposition for the comparisons. - Above implementation uses Comparable, so any future data types that implement that interface should get supported for free - Add a bunch more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the string concatenation operator (+) is used in cases where it isn't appropriate so that, for example
"1/1/1990".toDate() + 1converts the values to strings and concatenates them, which is almost certainly not what the user expects.Current Results
The binary addition operator (+) results in string concatenation when used with anything except two numbers which is overly greedy behavior.
Expected Behavior
String concatenation should be limited to cases where at least one operand is a string. Unsupported cases (e.g. date + integer) should be an error (which just returns
nullin current GREL conventions).The text was updated successfully, but these errors were encountered: