[I# 1011] Second implementation of facet renaming #5759
Conversation
github-actions
bot
added
Type: Feature Request
This reverts commit b2da495.
Return human string instead of `<core-views/non-blank-values>` in the ToolTip
Use label to get Facet name.
|
@wetneb : I've changed the Source Did I understand your reservation in the meeting? Does this address it? This should be finished, all tests passed. Regards, |
There was a problem hiding this comment.
Looks good but the following adjustments should be made:
Change 'Click here to edit the name of the facet' to 'Click to rename facet' so it is consistent with rename project verbiage:
There is no need to put the expression in the rename facet tooltip. The expression is visible in the 'change' tooltip, or by clicking 'change' to popup the expression dialog:
| "filter(row.columnNames,cn,isNonBlank(cells[cn].value))": | ||
| { source: "<non-blank-values>", label: 'core-views/non-blank-values' }, | ||
| "filter(row.columnNames,cn,isNonBlank(if(row.record.fromRowIndex==row.index,row.record.cells[cn].value.join(\"\"),null)))": | ||
| { source: "<non-blank-records>", label: 'core-views/non-blank-records' } |
There was a problem hiding this comment.
I would rather store this mapping in the definition of the facets themselves (in the menu). Because it is likely that people forget to update this when they add a new facet in that menu, or for instance when an extension registers a facet there. I think this could be done simply changing the method which adds a new facet, so that the facet name can be set directly there.
cooperzoe
removed
the
design proposal needed
Fixes #1011
Changes proposed in this pull request: